[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480216593



##########
File path: solr/docker/tests/shared.sh
##########
@@ -90,18 +90,44 @@ function prepare_dir_to_mount {
   fi
   rm -fr "$folder" >/dev/null 2>&1
   mkdir "$folder"
-  #echo "***** Created varsolr folder $PWD / $folder"
+  #echo "***** Created varsolr folder $BUILD_DIR / $folder"
 
   # The /var/solr mountpoint is owned by solr, so when we bind mount there our directory,
   # owned by the current user in the host, will show as owned by solr, and our attempts
   # to write to it as the user will fail. To deal with that, set the ACL to allow that.
   # If you can't use setfacl (eg on macOS), you'll have to chown the directory to 8983, or apply world
   # write permissions.
-  if [[ "$OSTYPE" == "darwin"* ]]; then
-    # Workaround for macOS
-    sudo chmod -R 777 "$folder"
-    sudo chown -R "$userid" "$folder"
-  else
+  if command -v setfacl &> /dev/null; then
     setfacl -m "u:$userid:rwx" "$folder"
   fi
 }
+
+
+# Shared setup

Review comment:
       These changes were necessary for separating out the test output from the source directory from the tests as well as having unique container names for the tests. This was needed in the migration, because the tests assumed that you were running in a particular directory layout before (the layout in docker-solr). Moving to gradle, this needed to be a lot more flexible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org