You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Jeff Kim (Jira)" <ji...@apache.org> on 2021/06/29 06:18:00 UTC

[jira] [Created] (KAFKA-13007) KafkaAdminClient getListOffsetsCalls builds cluster snapshot for every topic partition

Jeff Kim created KAFKA-13007:
--------------------------------

             Summary: KafkaAdminClient getListOffsetsCalls builds cluster snapshot for every topic partition
                 Key: KAFKA-13007
                 URL: https://issues.apache.org/jira/browse/KAFKA-13007
             Project: Kafka
          Issue Type: Bug
          Components: clients
    Affects Versions: 2.8.0
            Reporter: Jeff Kim
            Assignee: Jeff Kim


From KafkaAdminClient#getListOffsetsCalls:

```
for (Map.Entry<TopicPartition, OffsetSpec> entry: topicPartitionOffsets.entrySet()) {
            ...
                Node node = mr.cluster().leaderFor(tp);
```

here we build the cluster snapshot for each topic partition. instead, we should reuse a snapshot. this will reduce the time complexity from O(n^2) to O(n).


for manual testing (used AK 2.8), i've passed in a map of 6K topic partitions to listOffsets

without snapshot reuse:
duration of building futures from metadata response: 15582 milliseconds
total duration of listOffsets: 15743 milliseconds

with reuse:
duration of building futures from metadata response: 24 milliseconds
total duration of listOffsets: 235 milliseconds

Affects all versions since Admin & KafkaAdminClient introduced listOffsets (original PR: https://github.com/apache/kafka/pull/7296/files#diff-5422d10d9a7f4776c6538ae3aea27f24e94cf4ecf5e752040125aca6edc795d3R3673)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)