[jira] [Commented] (HUDI-304) Bring back spotless plugin

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408418#comment-17408418 ] 

ASF GitHub Bot commented on HUDI-304:
-------------------------------------

vinothchandar commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910861287


   @xushiyan we should probably pick this back up sometime? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bring back spotless plugin 
> ---------------------------
>
>                 Key: HUDI-304
>                 URL: https://issues.apache.org/jira/browse/HUDI-304
>             Project: Apache Hudi
>          Issue Type: Task
>          Components: Code Cleanup, Testing
>            Reporter: Balaji Varadarajan
>            Assignee: Raymond Xu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> spotless plugin has been turned off as the eclipse style format it was referencing was removed due to compliance reasons. 
> We use google style eclipse format with some changes
> 90c90
> < <setting id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/>
> ---
> > <setting id="org.eclipse.jdt.core.formatter.lineSplit" value="120"/>
> 242c242
> < <setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="100"/>
> ---
> > <setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="120"/>
>  
> The eclipse style sheet was originally obtained from [https://github.com/google/styleguide] which CC -By 3.0 license which is not compatible for source distribution (See [https://www.apache.org/legal/resolved.html#cc-by]) 
>  
> We need to figure out a way to bring this back
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)