You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sh...@apache.org on 2006/07/17 21:44:08 UTC
svn commit: r422813 - in /myfaces/tomahawk/trunk/sandbox/core/src/main:
java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java
resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js
Author: sharathreddy
Date: Mon Jul 17 12:44:07 2006
New Revision: 422813
URL: http://svn.apache.org/viewvc?rev=422813&view=rev
Log:
TableSuggestAjax: fixed a few javascript bugs for Internet Explorer compatibility
Modified:
myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java
myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js
Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java?rev=422813&r1=422812&r2=422813&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/tablesuggestajax/TableSuggestAjaxRenderer.java Mon Jul 17 12:44:07 2006
@@ -467,7 +467,6 @@
}
context.getExternalContext().getRequestMap().remove(tableSuggestAjax.getVar());
- System.out.println(response.toString());
context.getResponseWriter().write(response.toString());
}
@@ -488,8 +487,19 @@
}
Iterator columns = tableSuggestAjax.getChildren().iterator();
+ boolean first = true;
while (columns.hasNext())
{
+
+ if (first)
+ {
+ first = false;
+ }
+ else
+ {
+ fieldNames.append(",");
+ }
+
UIComponent column = (UIComponent) columns.next();
Iterator columnChildren = column.getChildren().iterator();
@@ -512,7 +522,7 @@
tableSuggestAjax,
htmlOutputText.getFor());
- fieldNames.append("\"" + fieldName + "\",");
+ fieldNames.append("\"" + fieldName + "\"");
}
//foreign-key field is a combo-box field
@@ -521,11 +531,11 @@
String fieldName = RendererUtils.getClientId(context,
tableSuggestAjax,
htmlOutputText.getForValue());
- fieldNames.append("\"" + fieldName + "\",");
+ fieldNames.append("\"" + fieldName + "\"");
}
}
}
-
+
fieldNames.append("]");
return fieldNames.toString();
}
@@ -663,7 +673,6 @@
}
}
}
- System.out.println(columnHeaders.toString());
context.getResponseWriter().write(columnHeaders.toString());
}
Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js?rev=422813&r1=422812&r2=422813&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/suggestajax/tablesuggestajax/resource/tableSuggest.js Mon Jul 17 12:44:07 2006
@@ -102,10 +102,17 @@
org_apache_myfaces_TableSuggest.prototype.typeAhead = function(suggestion)
{
- if (this.inputField.createTextRange || this.inputField.setSelectionRange)
+ var len = this.inputField.value.length;
+ this.inputField.value = suggestion;
+
+ if (this.inputField.createTextRange)
{
- var len = this.inputField.value.length;
- this.inputField.value = suggestion;
+ var range = this.inputField.createTextRange();
+ range.moveStart("character", len);
+ range.moveEnd("character", suggestion.length - len);
+ range.select();
+ }
+ else if (this.inputField.setSelectionRange) {
this.inputField.setSelectionRange(len, suggestion.length);
}
}
@@ -351,7 +358,8 @@
var evt = (event) ? event : window.event;
//find the enclosing tr element
- var obj = evt.target.parentNode;
+ var target = evt.target || evt.srcElement;
+ var obj = target.parentNode;
while (obj.tagName != 'TR')
{
obj = obj.parentNode;