You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <ma...@gmail.com> on 2013/05/07 22:36:31 UTC

Running JavaHL from win-tests.py

I just noticed that win-tests.py has a --javahl option.  This is cool,
but it does not work.  The reason is that it refers to a junit Python
object that is not defined.  In my case, I just removed it since I
have junit.jar in the lib/ext folder for my JRE.  I am guessing
someone planned to add a --junit option of some kind?  Not sure the
right change, so I am not attempting a patch.

This was with 1.8.0-rc1 but I assume trunk has same problem.

It is nice to be able to run the tests this way since it sets up
everything needed.  Removing the Junit reference caused the tests to
run for me.

--
Thanks

Mark Phippard
http://markphip.blogspot.com/

RE: Running JavaHL from win-tests.py

Posted by Bert Huijben <be...@qqmail.nl>.

> -----Original Message-----
> From: Mark Phippard [mailto:markphip@gmail.com]
> Sent: woensdag 8 mei 2013 15:32
> To: Bert Huijben
> Cc: Subversion Development
> Subject: Re: Running JavaHL from win-tests.py
> 
> On Wed, May 8, 2013 at 2:54 AM, Bert Huijben <be...@qqmail.nl> wrote:
> > On the windows builbot I pass the junit location to gen-make.py and then
I
> > can compile and run the junit tests. I also need the junit location
during
> > building as it is not installed in the standard environment.
> >
> > The exact invocations are in the buildbot directory of our source tree.
(And
> > if I remember correctly we also use this for 1.7)
> 
> I thought of that after I sent the email.  So you are saying if you
> specify --with-junit when running gen-make.py that configures
> something somewhere that allows win-tests.py to know where to look for
> junit?

gen-make.py stores its arguments in gen-make.opts. This file is also used by
win-tests.py to find the binaries to copy for running the tests.

> 
> Do these settings do anything else?  For example do they make building
> __ALL_TESTS__ and build JavaHL and the JavaHL tests?  Currently, I run
> that build target separately.

The path is also used in the generated javahl test projects to provide a
reference to this file to the compiler, so it doesn't provide a class not
found error.

gen-make.py and win-tests.py don't run any build commands for you. 

There are __JAVAHL__ and __JAVAHL_TESTS__ targets in the generated .sln
(when javahl is enabled). win-tests.py doesn't do that for the normal
testsuite either.

	Bert
> 
> --
> Thanks
> 
> Mark Phippard
> http://markphip.blogspot.com/


Re: Running JavaHL from win-tests.py

Posted by Mark Phippard <ma...@gmail.com>.
On Wed, May 8, 2013 at 2:54 AM, Bert Huijben <be...@qqmail.nl> wrote:
> On the windows builbot I pass the junit location to gen-make.py and then I
> can compile and run the junit tests. I also need the junit location during
> building as it is not installed in the standard environment.
>
> The exact invocations are in the buildbot directory of our source tree. (And
> if I remember correctly we also use this for 1.7)

I thought of that after I sent the email.  So you are saying if you
specify --with-junit when running gen-make.py that configures
something somewhere that allows win-tests.py to know where to look for
junit?

Do these settings do anything else?  For example do they make building
__ALL_TESTS__ and build JavaHL and the JavaHL tests?  Currently, I run
that build target separately.

--
Thanks

Mark Phippard
http://markphip.blogspot.com/

Re: Running JavaHL from win-tests.py

Posted by Bert Huijben <be...@qqmail.nl>.
On the windows builbot I pass the junit location to gen-make.py and then I can compile and run the junit tests. I also need the junit location during building as it is not installed in the standard environment.


The exact invocations are in the buildbot directory of our source tree. (And if I remember correctly we also use this for 1.7)


Bert 



Sent from Windows Mail



From: Mark Phippard
Sent: ‎Tuesday‎, ‎May‎ ‎7‎, ‎2013 ‎10‎:‎36‎ ‎PM
To: Subversion Development

I just noticed that win-tests.py has a --javahl option.  This is cool,
but it does not work.  The reason is that it refers to a junit Python
object that is not defined.  In my case, I just removed it since I
have junit.jar in the lib/ext folder for my JRE.  I am guessing
someone planned to add a --junit option of some kind?  Not sure the
right change, so I am not attempting a patch.

This was with 1.8.0-rc1 but I assume trunk has same problem.

It is nice to be able to run the tests this way since it sets up
everything needed.  Removing the Junit reference caused the tests to
run for me.

--
Thanks

Mark Phippard
http://markphip.blogspot.com/