[GitHub] R-Bower commented on issue #3335: NIFI-5018

[GitBox <gi...@apache.org>]

R-Bower commented on issue #3335: NIFI-5018
URL: https://github.com/apache/nifi/pull/3335#issuecomment-467262825
 
 
   > Hi. I'm excited to try out this feature. I am concerned however, that changing the component sizes will have serious impacts on user experience, flow versioning & fingerprinting. I think there needs to be substantial testing on these integration points and either change how fingerprinting works, or provide a smooth transition/migration experience.
   > 
   > In addition, making this an immediate change without a boolean flag to turn it on/off will disrupt many users. I would suggest making both the snap pixel size and the feature itself configurable from nifi.properties.
   > 
   > Ideally, this would be a per-user setting on a NiFi instance, but that is a large requirement for this feature.
   
   Regarding the altered components:
   - Only four are modified.  These are listed above.
   - I've ensured that all of the size changes don't restrict or prevent content from displaying.  Canvas layouts update consistently from pre-existing configurations, but I don't have any testing in place to bolster the idea that no/minimal errors will occur from updating.  I've merely updated the JS width/height properties on these four components.  What are your predictions, re: potential conflicts that'd arise from altering those dimensions?
   
   I'll look into configuring the nifi.properties.  I don't imagine it'll be too difficult for this feature.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services