You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by Christian Schneider <ch...@die-schneider.net> on 2017/01/10 11:58:13 UTC
[Proxy] Some changes for next release
I would like to do some changes for the next release of Aries proxy:
- Remove dependency of proxy api to aries util. Currently this
dependency is only need for internationalization of the
FinalModifierException message. I do not think this makes sense for such
low level messages. So I would like to replace this with just a fixed
english message. I am not even sure anyone tried to create other
languages for this.
- Assume java 1.6. There are some checks for java 1.6. I think we can
remove them as it is unlikely anyone uses java 1.5 for the build
- Depend on OSGi 4.3. Currently we fine tune the imports for 4.2 compat.
I propose to depend on 4.3 and also make the weaving hook package import
mandatory. This should work with all half way current OSGi frameworks.
- We currently create a separate bundle combining API, Impl and aries
util. I propose to embed the API in the impl bundle by default and not
create a separate combined bundle.
Users of the proxy will always depend on the API in their build. As the
impl bundle is probably not using in user maven dependencies it should
not cause any trouble to embed the api there
WDYT?
Christian
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
Re: [Proxy] Some changes for next release
Posted by Christian Schneider <ch...@die-schneider.net>.
On 10.01.2017 13:56, Guillaume Nodet wrote:
> 2017-01-10 13:11 GMT+01:00 Guillaume Nodet <gn...@apache.org>:
>
>>
>> 2017-01-10 12:58 GMT+01:00 Christian Schneider <ch...@die-schneider.net>:
>>
>> - We currently create a separate bundle combining API, Impl and aries
>> util. I propose to embed the API in the impl bundle by default and not
>> create a separate combined bundle.
>> Users of the proxy will always depend on the API in their build. As the
>> impl bundle is probably not using in user maven dependencies it should not
>> cause any trouble to embed the api there
>>
> It seems there's already such a bundle, called proxy-bundle, so maybe we
> can avoid any disturbance and just release this bundle instead ?
What I try to do is make the build simpler and have less moving parts.
So my plan is to change the impl module to the maven ids of the bundle
module and embed the api.
So for users of the combined bundle nothing will change. Other users
have to change from the separate api, impl bundles to the combined bundle.
So the change for users is zero or small while our build will be
considerably simpler. For example we currently test both the combined
bundle as well as the separate bundles.
After the change we can remove quite a few then redundant tests.
From deployment side in karaf we currently use:
mvn:org.ow2.asm/asm-all/5.0.4 start-level=20
mvn:org.apache.aries/org.apache.aries.util/1.1.1 start-level=20
mvn:org.apache.aries.proxy/org.apache.aries.proxy.api/1.0.1
start-level=20
mvn:org.apache.aries.proxy/org.apache.aries.proxy.impl/1.0.5
start-level=20
After the change it would be:
mvn:org.ow2.asm/asm-all/5.0.4 start-level=20
mvn:org.apache.aries.proxy/org.apache.aries.proxy/1.1.0 start-level=20
Christian
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
Re: [Proxy] Some changes for next release
Posted by Guillaume Nodet <gn...@apache.org>.
2017-01-10 13:11 GMT+01:00 Guillaume Nodet <gn...@apache.org>:
>
>
> 2017-01-10 12:58 GMT+01:00 Christian Schneider <ch...@die-schneider.net>:
>
>> I would like to do some changes for the next release of Aries proxy:
>>
>> - Remove dependency of proxy api to aries util. Currently this dependency
>> is only need for internationalization of the FinalModifierException
>> message. I do not think this makes sense for such low level messages. So I
>> would like to replace this with just a fixed english message. I am not even
>> sure anyone tried to create other languages for this.
>>
>> - Assume java 1.6. There are some checks for java 1.6. I think we can
>> remove them as it is unlikely anyone uses java 1.5 for the build
>>
>> - Depend on OSGi 4.3. Currently we fine tune the imports for 4.2 compat.
>> I propose to depend on 4.3 and also make the weaving hook package import
>> mandatory. This should work with all half way current OSGi frameworks.
>>
>> - We currently create a separate bundle combining API, Impl and aries
>> util. I propose to embed the API in the impl bundle by default and not
>> create a separate combined bundle.
>> Users of the proxy will always depend on the API in their build. As the
>> impl bundle is probably not using in user maven dependencies it should not
>> cause any trouble to embed the api there
>>
>
It seems there's already such a bundle, called proxy-bundle, so maybe we
can avoid any disturbance and just release this bundle instead ?
>
> If so, we should make sure the api package is exported/imported.
>
>
>>
>> WDYT?
>>
>> Christian
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> http://www.talend.com
>>
>>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Red Hat, Open Source Integration
>
> Email: gnodet@redhat.com
> Web: http://fusesource.com
> Blog: http://gnodet.blogspot.com/
>
>
--
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration
Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/
Re: [Proxy] Some changes for next release
Posted by Guillaume Nodet <gn...@apache.org>.
2017-01-10 12:58 GMT+01:00 Christian Schneider <ch...@die-schneider.net>:
> I would like to do some changes for the next release of Aries proxy:
>
> - Remove dependency of proxy api to aries util. Currently this dependency
> is only need for internationalization of the FinalModifierException
> message. I do not think this makes sense for such low level messages. So I
> would like to replace this with just a fixed english message. I am not even
> sure anyone tried to create other languages for this.
>
> - Assume java 1.6. There are some checks for java 1.6. I think we can
> remove them as it is unlikely anyone uses java 1.5 for the build
>
> - Depend on OSGi 4.3. Currently we fine tune the imports for 4.2 compat. I
> propose to depend on 4.3 and also make the weaving hook package import
> mandatory. This should work with all half way current OSGi frameworks.
>
> - We currently create a separate bundle combining API, Impl and aries
> util. I propose to embed the API in the impl bundle by default and not
> create a separate combined bundle.
> Users of the proxy will always depend on the API in their build. As the
> impl bundle is probably not using in user maven dependencies it should not
> cause any trouble to embed the api there
>
If so, we should make sure the api package is exported/imported.
>
> WDYT?
>
> Christian
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> http://www.talend.com
>
>
--
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration
Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/