[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297163#comment-16297163 ] 

ASF GitHub Bot commented on NIFI-4410:
--------------------------------------

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2175
  
    So it is Elasticsearch that is treating "not found while deleting" differently than "not found while updating", they return different status codes with the "error" message in different fields in the JSON. This PR checks for both. I'm waffling on whether to treat them as errors, I think I'd like to keep them as not errors (see my comment above).
    @MikeThomsen Are you seeing "not-found-updates" as failures, and "not-found-deletes" as successful? If so then are you ok with that behavior? I'm tending towards keeping it that way.


> PutElasticsearchHttp needs better error handling and logging
> ------------------------------------------------------------
>
>                 Key: NIFI-4410
>                 URL: https://issues.apache.org/jira/browse/NIFI-4410
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Matt Burgess
>
> https://github.com/apache/nifi/blob/6b5015e39b4233cf230151fb45bebcb21df03730/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java#L364-L366
> If it cannot extract the reason text it provides a very generic error and there is nothing else logged.  You get no context as to what went wrong and further the condition doesn't cause yielding or anything so there is just a massive flood of errors in logs that dont' advise the user of the problem.
> We need to make sure the information can be made available to help troubleshoot and we need to cause yielding so that such cases do not cause continuous floods of errors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)