[GitHub] [hadoop] LiuGuH commented on pull request #5642: HDFS-17007. TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 test case is wrong

["LiuGuH (via GitHub)" <gi...@apache.org>]

LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545057769

         GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
             10000);
         // The pending queue should be empty.
         assertEquals("Size of pendingReconstructions ", 0,
             pendingReconstruction.size());
       } finally {
         if (cluster != null) {
           cluster.shutdown();
         }
       }
   
   GenericTestUtils.waitFor() will  sleep maximum 10s.  The pendingReconstruction  will timeout after 3s ，then will be into timeout list. 
   PendingReconstructionMonitor will not be stoped if I change  GenericTestUtils.waitFor to 1s .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org