You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/02 08:04:36 UTC

[GitHub] [beam] alexeyinkin commented on a diff in pull request #22960: Send JavaScript messages to Playground iframes when switching the language in docs (#22361)

alexeyinkin commented on code in PR #22960:
URL: https://github.com/apache/beam/pull/22960#discussion_r961399987


##########
website/www/site/assets/scss/_playground.sass:
##########
@@ -17,6 +17,14 @@
 
 @import "media"
 
+.code-snippet-playground
+  padding: 0
+  background: none!important

Review Comment:
   It overrides this `!important`: https://github.com/apache/beam/blob/acd0134ec61151336ccd49ff8a58b4d3675def6d/website/www/site/assets/scss/_global.sass#L112
   
   Which in turn overrides this grey background for snippets introduced 6 years ago:
   https://github.com/apache/beam/blob/acd0134ec61151336ccd49ff8a58b4d3675def6d/website/www/site/assets/scss/_syntax-highlighting.scss#L22
   
   I removed that and all `!important`s that grew from it and see no difference, thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org