You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/21 01:18:50 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #2959:
Routine load submit
morningman opened a new pull request #2959: Routine load submit
URL: https://github.com/apache/incubator-doris/pull/2959
NOT READY!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#2959: Routine load submit
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2959: Routine load submit
URL: https://github.com/apache/incubator-doris/pull/2959#discussion_r382583633
##########
File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java
##########
@@ -186,6 +186,7 @@ private void setOptionalFromRoutineLoadJob(RoutineLoadJob routineLoadJob) {
partitions = routineLoadJob.getPartitions() == null ? null : Joiner.on(",").join(routineLoadJob.getPartitions());
strictMode = routineLoadJob.isStrictMode();
timezone = routineLoadJob.getTimezone();
+ timeout = (int) routineLoadJob.getMaxBatchIntervalS() * 2;
Review comment:
Yes, previous we just use the Config.stream_load_default_timeout_second for the routine load task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request
#2959: Routine load submit
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #2959: Routine load submit
URL: https://github.com/apache/incubator-doris/pull/2959#discussion_r382486145
##########
File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java
##########
@@ -186,6 +186,7 @@ private void setOptionalFromRoutineLoadJob(RoutineLoadJob routineLoadJob) {
partitions = routineLoadJob.getPartitions() == null ? null : Joiner.on(",").join(routineLoadJob.getPartitions());
strictMode = routineLoadJob.isStrictMode();
timezone = routineLoadJob.getTimezone();
+ timeout = (int) routineLoadJob.getMaxBatchIntervalS() * 2;
Review comment:
Does FE send the timeout property to BE in query_options?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #2959:
[Bug][RoutineLoad] Fix bug that routine Load encounter "label already used"
exception
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #2959: [Bug][RoutineLoad] Fix bug that routine Load encounter "label already used" exception
URL: https://github.com/apache/incubator-doris/pull/2959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org