You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/03/13 14:21:30 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1452: SOLR-16393: Migrate alias-deletion to JAX-RS
gerlowskija opened a new pull request, #1452:
URL: https://github.com/apache/solr/pull/1452
https://issues.apache.org/jira/browse/SOLR-16393
# Description
Solr is in the process of migrating its v2 APIs over to a JAX-RS framework. This gives us a more feature-rich framework for expressing APIs, makes it easier for the APIs themselves to be more REST-ful and standardized, and also makes it easier for Solr to integrate with tooling such as OpenAPI, which can be used to autogenerate client bindings for a variety of different languages.
But many non-JAX-RS APIs remain.
# Solution
This commit migrates the "delete alias" API to the JAX-RS framework.
It also makes a few cosmetic changes to the v2 API to bring it closer into line with the more REST-ful design we're targeting for v2. Alias deletion now uses the API:
```
DELETE /api/aliases/aliasName
```
# Tests
Existing alias tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1452:
URL: https://github.com/apache/solr/pull/1452#issuecomment-1470094543
I've added some unit tests to cover the testing gap. Thought I'd done that earlier, my mistake.
> Also are we adding upgrade notes info for V2 API changes, or just CHANGES.txt entries?
I've been sticking to CHANGES.txt entries up to this point whenever a v2 API is added or modified. I hadn't done upgrade notes, primarily because of the evolving nature of the v2 APIs. I don't have a strong opinion either way there - I'd be happy to add an upgrade note that aggregates a lot of the CHANGES.txt entries, if you think that'd be valuable to folks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1452:
URL: https://github.com/apache/solr/pull/1452#issuecomment-1466419734
Still needs a CHANGES.txt entry to describe the change in v2 API, but otherwise 'test' and 'check' passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1452:
URL: https://github.com/apache/solr/pull/1452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1452: SOLR-16393: Migrate alias-deletion to JAX-RS
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1452:
URL: https://github.com/apache/solr/pull/1452#issuecomment-1470127328
Nah, that sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org