You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/31 04:06:18 UTC

[GitHub] [spark-website] dongjoon-hyun commented on a change in pull request #378: Contribution guide to document actual guide for pull requests

dongjoon-hyun commented on a change in pull request #378:
URL: https://github.com/apache/spark-website/pull/378#discussion_r795331797



##########
File path: contributing.md
##########
@@ -321,11 +321,17 @@ Example: `Fix typos in Foo scaladoc`
 `dev@spark.apache.org` first before proceeding to implement the change.
 
 <h3>Pull request</h3>
+Before creating a pull request in Apache Spark, it is important to check if tests can pass on your branch because 
+our GitHub Actions workflows automatically run tests for your pull request/following commits 
+and every run burdens the limited resources of GitHub Actions in Apache Spark repository.
+Below steps will take your through the process.
+
 
 1. <a href="https://help.github.com/articles/fork-a-repo/">Fork</a> the GitHub repository at 
 <a href="https://github.com/apache/spark">https://github.com/apache/spark</a> if you haven't already
-1. Clone your fork, create a new branch, push commits to the branch.
-1. Consider whether documentation or tests need to be added or updated as part of the change, 
+2. Go to "Actions" tab on your forked repository and enable "Build and test" and "Report test results" workflows  

Review comment:
       +1 for Sean's comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org