You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/12 10:31:11 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1420: [CELEBORN-516][PERF] Remove RPCSource since it cost too much CPU
AngersZhuuuu opened a new pull request, #1420:
URL: https://github.com/apache/incubator-celeborn/pull/1420
### What changes were proposed in this pull request?
<img width="1486" alt="截屏2023-04-12 下午6 30 40" src="https://user-images.githubusercontent.com/46485123/231431742-0401f483-5071-479e-bd09-b8e46a3a0f93.png">
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1420: [CELEBORN-516][PERF] Remove RPCSource since it cost too much CPU
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1420:
URL: https://github.com/apache/incubator-celeborn/pull/1420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1420: [CELEBORN-516][PERF] Remove RPCSource since it cost too much CPU
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1420:
URL: https://github.com/apache/incubator-celeborn/pull/1420#issuecomment-1505055721
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1420](https://codecov.io/gh/apache/incubator-celeborn/pull/1420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8ee7bd) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e5722126e9412b70175e7b9377704b1581105c33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e572212) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
- Coverage 44.91% 44.59% -0.32%
==========================================
Files 164 163 -1
Lines 10408 10315 -93
Branches 1056 1041 -15
==========================================
- Hits 4674 4599 -75
+ Misses 5395 5383 -12
+ Partials 339 333 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/celeborn/common/rpc/RpcEnv.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9ScGNFbnYuc2NhbGE=) | `61.91% <ø> (+2.82%)` | :arrow_up: |
| [...apache/celeborn/common/rpc/netty/NettyRpcEnv.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9OZXR0eVJwY0Vudi5zY2FsYQ==) | `16.49% <ø> (-0.06%)` | :arrow_down: |
... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1420/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org