You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jeffkbkim (via GitHub)" <gi...@apache.org> on 2023/07/21 01:06:46 UTC
[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error
jeffkbkim commented on code in PR #14046:
URL: https://github.com/apache/kafka/pull/14046#discussion_r1270133576
##########
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##########
@@ -31,13 +31,19 @@
// version 7 adds a new field called groupInstanceId to indicate member identity across restarts.
//
// Version 8 is the first flexible version.
- "validVersions": "0-8",
+ //
+ // Version 9 is the first version that can be used with the new consumer group protocol (KIP-848). The
+ // request is the same as version 8.
+ // Version 9 is added as part of KIP-848 and is still under development. Hence, the last version of the
+ // API is not exposed by default by brokers unless explicitly enabled.
+ "latestVersionUnstable": true,
+ "validVersions": "0-9",
"flexibleVersions": "8+",
"fields": [
{ "name": "GroupId", "type": "string", "versions": "0+", "entityType": "groupId",
"about": "The unique group identifier." },
- { "name": "GenerationId", "type": "int32", "versions": "1+", "default": "-1", "ignorable": true,
- "about": "The generation of the group." },
+ { "name": "GenerationIdOrMemberEpoch", "type": "int32", "versions": "1+", "default": "-1", "ignorable": true,
+ "about": "The generation of the group if the generic group protocol or the member epoch if the consumer protocol." },
Review Comment:
3 comments:
* is it safe to change the field name?
* > It based on the type of the group
you're saying based on the consumer since we can have a group with both new & old consumers right?
* nit: "if using ... if using ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org