[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1517: [core] compacted_full should never return null

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1517:
URL: https://github.com/apache/incubator-paimon/pull/1517#discussion_r1255684174


##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/CompactedStartingScanner.java:
##########
@@ -53,6 +54,6 @@ public Result scan(SnapshotManager snapshotManager, SnapshotReader snapshotReade
 
     @Nullable

Review Comment:
   Latest also can be nullable



##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/FullCompactedStartingScanner.java:
##########
@@ -40,7 +40,7 @@ public FullCompactedStartingScanner(int deltaCommits) {
     @Override
     @Nullable
     protected Long pick(SnapshotManager snapshotManager) {
-        return snapshotManager.pickFromLatest(this::picked);
+        return snapshotManager.pickOrLatest(this::picked);

Review Comment:
   Latest also can be nullable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org