You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2020/08/20 17:11:34 UTC
[beam] branch master updated: [BEAM-10770] Remove
DataflowPortabilityApiUnsupported annotation.
This is an automated email from the ASF dual-hosted git repository.
lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 899a03e [BEAM-10770] Remove DataflowPortabilityApiUnsupported annotation.
new c7e8c6b Merge pull request #12642 from ibzib/BEAM-10770
899a03e is described below
commit 899a03e8ab79da11e0b25dc5440a54db4c518c1e
Author: Kyle Weaver <kc...@google.com>
AuthorDate: Wed Aug 19 16:57:13 2020 -0700
[BEAM-10770] Remove DataflowPortabilityApiUnsupported annotation.
This annotation is obsolete; as of #11635 the Java runner harness is longer being tested.
---
runners/google-cloud-dataflow-java/build.gradle | 4 +-
.../testing/DataflowPortabilityApiUnsupported.java | 24 ----
.../org/apache/beam/sdk/io/CountingSourceTest.java | 7 +-
.../org/apache/beam/sdk/metrics/MetricsTest.java | 8 +-
.../org/apache/beam/sdk/testing/PAssertTest.java | 6 +-
.../apache/beam/sdk/transforms/CombineFnsTest.java | 7 +-
.../apache/beam/sdk/transforms/CombineTest.java | 31 ++----
.../apache/beam/sdk/transforms/GroupByKeyTest.java | 3 +-
.../beam/sdk/transforms/ParDoSchemaTest.java | 7 +-
.../org/apache/beam/sdk/transforms/ParDoTest.java | 122 ++++-----------------
.../beam/sdk/transforms/SplittableDoFnTest.java | 7 +-
.../org/apache/beam/sdk/transforms/ViewTest.java | 13 +--
.../beam/sdk/transforms/windowing/WindowTest.java | 3 +-
13 files changed, 49 insertions(+), 193 deletions(-)
diff --git a/runners/google-cloud-dataflow-java/build.gradle b/runners/google-cloud-dataflow-java/build.gradle
index d61b955..83464e0 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -309,9 +309,7 @@ task googleCloudPlatformFnApiWorkerIntegrationTest(type: Test) {
maxParallelForks 4
classpath = configurations.googleCloudPlatformIntegrationTest
testClassesDirs = files(project(":sdks:java:io:google-cloud-platform").sourceSets.test.output.classesDirs)
- useJUnit {
- excludeCategories 'org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported'
- }
+ useJUnit { }
}
task examplesJavaLegacyWorkerIntegrationTest(type: Test) {
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/DataflowPortabilityApiUnsupported.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/DataflowPortabilityApiUnsupported.java
deleted file mode 100644
index 1fd11ed..0000000
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/DataflowPortabilityApiUnsupported.java
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.beam.sdk.testing;
-
-import org.apache.beam.sdk.annotations.Internal;
-
-/** Category tag for the dataflow fn-api worker unsupported tests. */
-@Internal
-public interface DataflowPortabilityApiUnsupported {}
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
index 013cef7..720dcb9 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
@@ -30,7 +30,6 @@ import org.apache.beam.sdk.io.CountingSource.CounterMark;
import org.apache.beam.sdk.io.CountingSource.UnboundedCountingSource;
import org.apache.beam.sdk.io.UnboundedSource.UnboundedReader;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -95,8 +94,7 @@ public class CountingSourceTest {
@Test
@Category({
ValidatesRunner.class,
- UsesStatefulParDo.class, // This test fails if State is unsupported despite no direct usage.
- DataflowPortabilityApiUnsupported.class
+ UsesStatefulParDo.class // This test fails if State is unsupported despite no direct usage.
})
public void testBoundedSourceSplits() throws Exception {
long numElements = 1000;
@@ -221,8 +219,7 @@ public class CountingSourceTest {
@Test
@Category({
ValidatesRunner.class,
- UsesStatefulParDo.class, // This test fails if State is unsupported despite no direct usage.
- DataflowPortabilityApiUnsupported.class
+ UsesStatefulParDo.class // This test fails if State is unsupported despite no direct usage.
})
public void testUnboundedSourceSplits() throws Exception {
long numElements = 1000;
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java
index 6f7863d..284cba7 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java
@@ -29,7 +29,6 @@ import static org.mockito.Mockito.when;
import java.io.Serializable;
import org.apache.beam.sdk.PipelineResult;
import org.apache.beam.sdk.io.GenerateSequence;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.UsesAttemptedMetrics;
@@ -243,12 +242,7 @@ public class MetricsTest implements Serializable {
assertAllMetrics(metrics, true);
}
- @Category({
- ValidatesRunner.class,
- UsesCommittedMetrics.class,
- UsesCounterMetrics.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesCommittedMetrics.class, UsesCounterMetrics.class})
@Test
public void testCommittedCounterMetrics() {
PipelineResult result = runPipelineWithMetrics();
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
index 7d3d79f..46b0a37 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
@@ -171,7 +171,7 @@ public class PAssertTest implements Serializable {
* the {@link PCollection} to be serializable.
*/
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testContainsInAnyOrderNotSerializable() throws Exception {
PCollection<NotSerializableObject> pcollection =
pipeline.apply(
@@ -189,7 +189,7 @@ public class PAssertTest implements Serializable {
* arbitrary {@link SerializableFunction}, though.
*/
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testSerializablePredicate() throws Exception {
PCollection<NotSerializableObject> pcollection =
pipeline.apply(
@@ -210,7 +210,7 @@ public class PAssertTest implements Serializable {
* arbitrary {@link SerializableFunction}, though.
*/
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testWindowedSerializablePredicate() throws Exception {
PCollection<NotSerializableObject> pcollection =
pipeline
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
index 2a7d239..7182bf8 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
@@ -35,7 +35,6 @@ import org.apache.beam.sdk.coders.CoderException;
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.NullableCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.UsesSideInputs;
@@ -99,7 +98,7 @@ public class CombineFnsTest {
}
@Test
- @Category({ValidatesRunner.class, UsesSideInputs.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
public void testComposedCombine() {
p.getCoderRegistry().registerCoderForClass(UserString.class, UserStringCoder.of());
@@ -149,7 +148,7 @@ public class CombineFnsTest {
}
@Test
- @Category({ValidatesRunner.class, UsesSideInputs.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
public void testComposedCombineWithContext() {
p.getCoderRegistry().registerCoderForClass(UserString.class, UserStringCoder.of());
@@ -210,7 +209,7 @@ public class CombineFnsTest {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testComposedCombineNullValues() {
p.getCoderRegistry()
.registerCoderForClass(UserString.class, NullableCoder.of(UserStringCoder.of()));
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
index a8ca1cf..28554ac 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
@@ -53,7 +53,6 @@ import org.apache.beam.sdk.coders.SerializableCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.coders.VarIntCoder;
import org.apache.beam.sdk.coders.VoidCoder;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -652,11 +651,7 @@ public class CombineTest implements Serializable {
@RunWith(JUnit4.class)
public static class BasicTests extends SharedTestBase {
@Test
- @Category({
- ValidatesRunner.class,
- UsesSideInputs.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
@SuppressWarnings({"rawtypes", "unchecked"})
public void testSimpleCombine() {
runTestSimpleCombine(
@@ -666,11 +661,7 @@ public class CombineTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesSideInputs.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
public void testSimpleCombineEmpty() {
runTestSimpleCombine(EMPTY_TABLE, 0, Collections.emptyList());
}
@@ -707,7 +698,7 @@ public class CombineTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testHotKeyCombining() {
PCollection<KV<String, Integer>> input =
copy(
@@ -1037,7 +1028,7 @@ public class CombineTest implements Serializable {
@RunWith(JUnit4.class)
public static class WindowingTests extends SharedTestBase implements Serializable {
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testFixedWindowsCombine() {
PCollection<KV<String, Integer>> input =
pipeline
@@ -1320,7 +1311,7 @@ public class CombineTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testWindowedCombineEmpty() {
PCollection<Double> mean =
pipeline
@@ -1441,11 +1432,7 @@ public class CombineTest implements Serializable {
@RunWith(JUnit4.class)
public static class AccumulationTests extends SharedTestBase {
@Test
- @Category({
- ValidatesRunner.class,
- UsesSideInputs.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
public void testAccumulatingCombine() {
runTestAccumulatingCombine(
Arrays.asList(KV.of("a", 1), KV.of("a", 1), KV.of("a", 4), KV.of("b", 1), KV.of("b", 13)),
@@ -1454,11 +1441,7 @@ public class CombineTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesSideInputs.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesSideInputs.class})
public void testAccumulatingCombineEmpty() {
runTestAccumulatingCombine(EMPTY_TABLE, 0.0, Collections.emptyList());
}
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java
index 973ae10..e222754 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java
@@ -47,7 +47,6 @@ import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.MapCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.coders.VarIntCoder;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.LargeKeys;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
@@ -412,7 +411,7 @@ public class GroupByKeyTest implements Serializable {
/** Verify that runners correctly hash/group on the encoded value and not the value itself. */
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testGroupByKeyWithBadEqualsHashCode() throws Exception {
final int numValues = 10;
final int numKeys = 5;
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoSchemaTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoSchemaTest.java
index 0f9ce63..9eee454 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoSchemaTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoSchemaTest.java
@@ -43,7 +43,6 @@ import org.apache.beam.sdk.state.MapState;
import org.apache.beam.sdk.state.SetState;
import org.apache.beam.sdk.state.StateSpec;
import org.apache.beam.sdk.state.StateSpecs;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -653,7 +652,7 @@ public class ParDoSchemaTest implements Serializable {
}
@Test
- @Category({NeedsRunner.class, UsesStatefulParDo.class, DataflowPortabilityApiUnsupported.class})
+ @Category({NeedsRunner.class, UsesStatefulParDo.class})
public void testRowBagState() {
final String stateId = "foo";
@@ -719,7 +718,7 @@ public class ParDoSchemaTest implements Serializable {
}
@Test
- @Category({NeedsRunner.class, UsesStatefulParDo.class, DataflowPortabilityApiUnsupported.class})
+ @Category({NeedsRunner.class, UsesStatefulParDo.class})
public void tesBagStateSchemaInference() throws NoSuchSchemaException {
final String stateId = "foo";
@@ -769,7 +768,7 @@ public class ParDoSchemaTest implements Serializable {
}
@Test
- @Category({NeedsRunner.class, UsesStatefulParDo.class, DataflowPortabilityApiUnsupported.class})
+ @Category({NeedsRunner.class, UsesStatefulParDo.class})
public void testSetStateSchemaInference() throws NoSuchSchemaException {
final String stateId = "foo";
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
index e7cd5bb..374f6b0 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
@@ -91,7 +91,6 @@ import org.apache.beam.sdk.state.TimerMap;
import org.apache.beam.sdk.state.TimerSpec;
import org.apache.beam.sdk.state.TimerSpecs;
import org.apache.beam.sdk.state.ValueState;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -2027,11 +2026,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testCoderInferenceOfList() {
final String stateId = "foo";
MyIntegerCoder myIntegerCoder = MyIntegerCoder.of();
@@ -2071,11 +2066,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testValueStateFixedWindows() {
final String stateId = "foo";
@@ -2174,11 +2165,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testValueStateTaggedOutput() {
final String stateId = "foo";
@@ -2229,11 +2216,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testBagState() {
final String stateId = "foo";
@@ -2960,11 +2943,7 @@ public class ParDoTest implements Serializable {
@RunWith(JUnit4.class)
public static class StateCoderInferenceTests extends SharedTestBase implements Serializable {
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testBagStateCoderInference() {
final String stateId = "foo";
Coder<MyInteger> myIntegerCoder = MyIntegerCoder.of();
@@ -3446,11 +3425,7 @@ public class ParDoTest implements Serializable {
* hooks and is only supported by the direct runner.
*/
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testEventTimeTimerBounded() throws Exception {
final String timerId = "foo";
@@ -3484,11 +3459,7 @@ public class ParDoTest implements Serializable {
* case where both GBK and the user code share a timer delivery bundle.
*/
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testGbkFollowedByUserTimers() throws Exception {
DoFn<KV<String, Iterable<Integer>>, Integer> fn =
@@ -3523,11 +3494,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testEventTimeTimerAlignBounded() throws Exception {
final String timerId = "foo";
@@ -3562,11 +3529,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testTimerReceivedInOriginalWindow() throws Exception {
final String timerId = "foo";
@@ -3616,11 +3579,7 @@ public class ParDoTest implements Serializable {
* #testEventTimeTimerBounded()}.
*/
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testEventTimeTimerAbsolute() throws Exception {
final String timerId = "foo";
@@ -3700,11 +3659,7 @@ public class ParDoTest implements Serializable {
* implementations that may GC in ways not simply governed by the watermark.
*/
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testEventTimeTimerMultipleKeys() throws Exception {
final String timerId = "foo";
final String stateId = "sizzle";
@@ -3765,11 +3720,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testAbsoluteProcessingTimeTimerRejected() throws Exception {
final String timerId = "foo";
@@ -3806,11 +3757,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testOutOfBoundsEventTimeTimer() throws Exception {
final String timerId = "foo";
@@ -3850,22 +3797,13 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testOutputTimestampDefaultBounded() throws Exception {
runTestOutputTimestampDefault(false);
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesUnboundedPCollections.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesUnboundedPCollections.class, UsesTimersInParDo.class})
public void testOutputTimestampDefaultUnbounded() throws Exception {
runTestOutputTimestampDefault(true);
}
@@ -3903,11 +3841,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testOutOfBoundsEventTimeTimerHold() throws Exception {
final String timerId = "foo";
@@ -3949,11 +3883,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testOutOfBoundsProcessingTimeTimerHold() throws Exception {
final String timerId = "foo";
@@ -4430,11 +4360,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesTimersInParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesTimersInParDo.class})
public void testPipelineOptionsParameterOnTimer() {
final String timerId = "thisTimer";
@@ -4798,11 +4724,7 @@ public class ParDoTest implements Serializable {
@RunWith(JUnit4.class)
public static class TimerCoderInferenceTests extends SharedTestBase implements Serializable {
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testValueStateCoderInference() {
final String stateId = "foo";
MyIntegerCoder myIntegerCoder = MyIntegerCoder.of();
@@ -4868,11 +4790,7 @@ public class ParDoTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesStatefulParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesStatefulParDo.class})
public void testValueStateCoderInferenceFromInputCoder() {
final String stateId = "foo";
MyIntegerCoder myIntegerCoder = MyIntegerCoder.of();
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
index b940032..8d85601 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SplittableDoFnTest.java
@@ -38,7 +38,6 @@ import org.apache.beam.sdk.coders.BigEndianIntegerCoder;
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.io.range.OffsetRange;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -293,11 +292,7 @@ public class SplittableDoFnTest implements Serializable {
}
@Test
- @Category({
- ValidatesRunner.class,
- UsesBoundedSplittableParDo.class,
- DataflowPortabilityApiUnsupported.class
- })
+ @Category({ValidatesRunner.class, UsesBoundedSplittableParDo.class})
public void testOutputAfterCheckpointBounded() {
testOutputAfterCheckpoint(IsBounded.BOUNDED);
}
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
index 9f8d343..4014a3c 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
@@ -45,7 +45,6 @@ import org.apache.beam.sdk.coders.NullableCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.coders.VarIntCoder;
import org.apache.beam.sdk.coders.VoidCoder;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -612,7 +611,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testMultimapSideInputWithNonDeterministicKeyCoder() {
final PCollectionView<Map<String, Iterable<Integer>>> view =
@@ -748,7 +747,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testWindowedMultimapSideInputWithNonDeterministicKeyCoder() {
final PCollectionView<Map<String, Iterable<Integer>>> view =
@@ -831,7 +830,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testEmptyMultimapSideInputWithNonDeterministicKeyCoder() throws Exception {
final PCollectionView<Map<String, Iterable<Integer>>> view =
@@ -978,7 +977,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testMapSideInputWithNonDeterministicKeyCoder() {
final PCollectionView<Map<String, Integer>> view =
@@ -1100,7 +1099,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testWindowedMapSideInputWithNonDeterministicKeyCoder() {
final PCollectionView<Map<String, Integer>> view =
@@ -1178,7 +1177,7 @@ public class ViewTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testEmptyMapSideInputWithNonDeterministicKeyCoder() throws Exception {
final PCollectionView<Map<String, Integer>> view =
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
index 84e69d3..b1ac59b 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
@@ -50,7 +50,6 @@ import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.coders.VarIntCoder;
import org.apache.beam.sdk.io.GenerateSequence;
import org.apache.beam.sdk.runners.TransformHierarchy;
-import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.UsesCustomWindowMerging;
@@ -388,7 +387,7 @@ public class WindowTest implements Serializable {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class})
public void testNoWindowFnDoesNotReassignWindows() {
pipeline.enableAbandonedNodeEnforcement(true);