You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2017/11/14 00:30:26 UTC
BP-18: LedgerType, Flags and StorageHints
Hi all,
This is a proposal for introducing LedgerType, Flags and StorageHints
(after a discussion with JV and Enrico on Slack). It is to address the
confusions at BP-14. Please take a look and give me feedback.
https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-18%3A+LedgerType%2C+Flags+and+StorageHints
- Sijie
Re: BP-18: LedgerType, Flags and StorageHints
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Nov 13, 2017 at 11:57 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Il mar 14 nov 2017, 08:53 Sijie Guo <gu...@gmail.com> ha scritto:
>
> > On Mon, Nov 13, 2017 at 11:29 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Thank you Sijie,
> > > Overall looks good but the compatibility part could be enhanced at
> least
> > > writing that ledgers created with non default ledgertype and
> storagehints
> > > won't we accessible from old clients.
> >
> >
> > sure I will improve it. but frankly speaking, we should first switch
> ledger
> > metadata from text format to binary format, then implement this. The text
> > format is a huge trouble to extensibility. Also, client doesn't use
> ledger
> > type and storage hints directly.
> >
>
> Has already said, +1 for me for the switch. I wonder if we should enable
> the 4.6 or 4.5 clients to read binary metadata, in order to support the
> migration smoothly
> Enrico
>
No. it should be in 4.7. Switching to binary metadata should be treated as
a new feature. Only bug fixes are allowed in 4.6 and 4.5.
- Sijie
>
> >
> > I know that this is very common but
> > > an explicit statement would be meaningful in this case.
> > >
> > > Enrico
> > >
> > > Il mar 14 nov 2017, 01:30 Sijie Guo <gu...@gmail.com> ha scritto:
> > >
> > > > Hi all,
> > > >
> > > > This is a proposal for introducing LedgerType, Flags and StorageHints
> > > > (after a discussion with JV and Enrico on Slack). It is to address
> the
> > > > confusions at BP-14. Please take a look and give me feedback.
> > > >
> > > >
> > > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > > BP-18%3A+LedgerType%2C+Flags+and+StorageHints
> > > >
> > > > - Sijie
> > > >
> > > --
> > >
> > >
> > > -- Enrico Olivelli
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Re: BP-18: LedgerType, Flags and StorageHints
Posted by Enrico Olivelli <eo...@gmail.com>.
Il mar 14 nov 2017, 08:53 Sijie Guo <gu...@gmail.com> ha scritto:
> On Mon, Nov 13, 2017 at 11:29 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Thank you Sijie,
> > Overall looks good but the compatibility part could be enhanced at least
> > writing that ledgers created with non default ledgertype and storagehints
> > won't we accessible from old clients.
>
>
> sure I will improve it. but frankly speaking, we should first switch ledger
> metadata from text format to binary format, then implement this. The text
> format is a huge trouble to extensibility. Also, client doesn't use ledger
> type and storage hints directly.
>
Has already said, +1 for me for the switch. I wonder if we should enable
the 4.6 or 4.5 clients to read binary metadata, in order to support the
migration smoothly
Enrico
>
> I know that this is very common but
> > an explicit statement would be meaningful in this case.
> >
> > Enrico
> >
> > Il mar 14 nov 2017, 01:30 Sijie Guo <gu...@gmail.com> ha scritto:
> >
> > > Hi all,
> > >
> > > This is a proposal for introducing LedgerType, Flags and StorageHints
> > > (after a discussion with JV and Enrico on Slack). It is to address the
> > > confusions at BP-14. Please take a look and give me feedback.
> > >
> > >
> > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > BP-18%3A+LedgerType%2C+Flags+and+StorageHints
> > >
> > > - Sijie
> > >
> > --
> >
> >
> > -- Enrico Olivelli
> >
>
--
-- Enrico Olivelli
Re: BP-18: LedgerType, Flags and StorageHints
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Nov 13, 2017 at 11:29 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Thank you Sijie,
> Overall looks good but the compatibility part could be enhanced at least
> writing that ledgers created with non default ledgertype and storagehints
> won't we accessible from old clients.
sure I will improve it. but frankly speaking, we should first switch ledger
metadata from text format to binary format, then implement this. The text
format is a huge trouble to extensibility. Also, client doesn't use ledger
type and storage hints directly.
I know that this is very common but
> an explicit statement would be meaningful in this case.
>
> Enrico
>
> Il mar 14 nov 2017, 01:30 Sijie Guo <gu...@gmail.com> ha scritto:
>
> > Hi all,
> >
> > This is a proposal for introducing LedgerType, Flags and StorageHints
> > (after a discussion with JV and Enrico on Slack). It is to address the
> > confusions at BP-14. Please take a look and give me feedback.
> >
> >
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> BP-18%3A+LedgerType%2C+Flags+and+StorageHints
> >
> > - Sijie
> >
> --
>
>
> -- Enrico Olivelli
>
Re: BP-18: LedgerType, Flags and StorageHints
Posted by Enrico Olivelli <eo...@gmail.com>.
Thank you Sijie,
Overall looks good but the compatibility part could be enhanced at least
writing that ledgers created with non default ledgertype and storagehints
won't we accessible from old clients. I know that this is very common but
an explicit statement would be meaningful in this case.
Enrico
Il mar 14 nov 2017, 01:30 Sijie Guo <gu...@gmail.com> ha scritto:
> Hi all,
>
> This is a proposal for introducing LedgerType, Flags and StorageHints
> (after a discussion with JV and Enrico on Slack). It is to address the
> confusions at BP-14. Please take a look and give me feedback.
>
>
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-18%3A+LedgerType%2C+Flags+and+StorageHints
>
> - Sijie
>
--
-- Enrico Olivelli