You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 18:57:19 UTC

[GitHub] [airflow] atolopko-czi opened a new issue #13114: Improve DAG operator status accessibility for the color blind

atolopko-czi opened a new issue #13114:
URL: https://github.com/apache/airflow/issues/13114


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   The coloration of DAG operator statuses in the DAG "Tree" and "Graph" views are not easy to discern by color blind individuals. There is no textual representation of the status in the hover popup window.
   
   <!-- A short description of your feature -->
   
   **Use case / motivation**
   
   <!-- What do you want to happen?
   
   Provide an alternate means by which color blind individuals can ascertain the status of a DAG operator that does not rely upon color. Use of shapes or textual codes for the operator would be nice. Minimally, place the textual status in the hover popup.
   -->
   
   **Are you willing to submit a PR?**
   
   Yes
   
   <!--- We accept contributions! -->
   
   **Related Issues**
   
   <!-- Is there currently another issue associated with this? -->
   
   No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-769750264


   @atolopko-czi Do you think there are still issues needs to be addressed?  If you can please describe your suggestions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-746828688


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atolopko-czi commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
atolopko-czi commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-771122559


   I still feel it is helpful if the Tree view status hover popups simply contained the operator status as text. Colors can be useful conveyors of information, but text is more accessible for the color-blind. I have not tried setting different default colors, since that would require consensus across our organization.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-747340679


   And if you can suggest new default colours we can look at changing them too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-746909351


   What Airflow version are you running? There has been improve in that area in 1.10.11 
   see issue https://github.com/apache/airflow/issues/7843, PR https://github.com/apache/airflow/pull/9520, [docs](https://airflow.apache.org/docs/apache-airflow/stable/howto/customize-state-colors-ui.html) 
    
    
   Also in Graph View when you over one of the statuses in the legend it makes all the tasks in that status highlighted:
   ![video](https://user-images.githubusercontent.com/45845474/102398072-7b168200-3fe7-11eb-95d5-b378ece02209.gif)
   
   
   Can you give more information? (maybe a mock up of what you expect?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atolopko-czi commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
atolopko-czi commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-771184958


   Will upgrade! Thanks @kaxil!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-747126089


   You can customize those colors: https://airflow.readthedocs.io/en/stable/howto/customize-state-colors-ui.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atolopko-czi closed issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
atolopko-czi closed issue #13114:
URL: https://github.com/apache/airflow/issues/13114


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-771133201


   ![image](https://user-images.githubusercontent.com/8811558/106513750-42653600-64cb-11eb-99b2-7f1b96f2f659.png)
   
   The tree view in 2.0.0 should already have that 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atolopko-czi commented on issue #13114: Improve DAG operator status accessibility for the color blind

Posted by GitBox <gi...@apache.org>.
atolopko-czi commented on issue #13114:
URL: https://github.com/apache/airflow/issues/13114#issuecomment-747062181


   Version : 1.10.10
   
   The Tree view status-hover highlighting is indeed helpful, and I was unaware! The Graph view doesn't provide the same feature, which would be helpful.  So it would still be helpful if these popups contained the operator status: 
   ![image](https://user-images.githubusercontent.com/29237884/102410411-84d7bf80-3fbe-11eb-92c1-0d23cf320d82.png)
   
   Use of custom colors may also be able to address this for particular degrees of color blindness, which I will try.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org