You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/04/10 14:35:25 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #35005: GH-35004: [C++] Remove output mapping translation

rtpsw commented on code in PR #35005:
URL: https://github.com/apache/arrow/pull/35005#discussion_r1161773217


##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -4356,7 +4356,7 @@ TEST(Substrait, PlanWithAsOfJoinExtension) {
           "extension_multi": {
             "common": {
               "emit": {
-                "outputMapping": [0, 1, 2, 5]
+                "outputMapping": [0, 1, 2, 3]

Review Comment:
   Before these indices where input indices but now they are output indices. The output schema has these columns: "time", "key", "value1", "value2".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org