[GitHub] nikrao commented on issue #7251: update sparse ndarray api

[gi...@git.apache.org]

nikrao commented on issue #7251: update sparse ndarray api 
URL: https://github.com/apache/incubator-mxnet/pull/7251#issuecomment-319118001
 
 
   It's best to keep it consistent with MXNet nomenclature in general, so if
   it's "X" and "BaseX" for other classes, I think it's nice to have
   BaseSparseNDArray
   
   Nikhil
   
   On Sun, Jul 30, 2017 at 9:20 PM, Haibin Lin <no...@github.com>
   wrote:
   
   > *@eric-haibin-lin* commented on this pull request.
   > ------------------------------
   >
   > In python/mxnet/ndarray/__init__.py
   > <https://github.com/apache/incubator-mxnet/pull/7251#discussion_r130270026>
   > :
   >
   > >  from .ndarray import lesser, lesser_equal, maximum, minimum, moveaxis, multiply, negative, not_equal
   >  from .ndarray import onehot_encode, power, subtract, true_divide, waitall, _new_empty_handle
   > -from .ndarray_utils import load, save, zeros
   > -from .sparse_ndarray import _ndarray_cls
   > -from .sparse_ndarray import csr, row_sparse, SparseNDArray, todense, RowSparseNDArray, CSRNDArray
   > +from .ndarray_utils import load, save, zeros, empty, array
   > +from .sparse_ndarray import _ndarray_cls, todense
   > +from .sparse_ndarray import csr, row_sparse, BaseSparseNDArray, RowSparseNDArray, CSRNDArray
   >
   > NDArrayBase is not exposed to users. Since we also have BaseModule and
   > Module, I thought BaseSparseNDArray could indicate the same thing. @nikrao
   > <https://github.com/nikrao> what name do you think is better to use as
   > the base class for CSRNDArray and RowSparseNDArray?
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-mxnet/pull/7251#discussion_r130270026>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ASlOLGSy8FjU18H1stMjA9FVkrlBewLQks5sTVX6gaJpZM4OniNX>
   > .
   >
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services