[GitHub] [kafka] OmniaGM commented on a change in pull request #11220: KAFKA-10777: Add additional configuration to control MirrorMaker 2 internal topics naming convention

[GitBox <gi...@apache.org>]

OmniaGM commented on a change in pull request #11220:
URL: https://github.com/apache/kafka/pull/11220#discussion_r722666580



##########
File path: connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/ReplicationPolicy.java
##########
@@ -52,9 +52,39 @@ default String originalTopic(String topic) {
         }
     }
 
+    /** Returns heartbeats topic name.*/
+    default String heartbeatsTopic() {
+        return "heartbeats";
+    }
+
+    /** Returns the offset-syncs topic for given cluster alias. */
+    default String offsetSyncTopic(String clusterAlias) {
+        return "mm2-offset-syncs." + clusterAlias + ".internal";
+    }
+
+    /** Returns the name checkpoint topic for given cluster alias. */
+    default String checkpointTopic(String clusterAlias) {
+        return clusterAlias + ".checkpoint.internal";

Review comment:
       > This topic is currently named .checkpoints.internal, see https://github.com/apache/kafka/blob/trunk/connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java#L60. We need to keep the current name
   
   Good spot
   
   > Can we also rationalize the different names. Ig uess this method should be checkpointsTopic.
   
   make sense, will update the KIP as well to reflect this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org