You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/21 05:28:29 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #37931: [SPARK-40488] Do not wrap exceptions thrown when datasource write fails

cloud-fan commented on code in PR #37931:
URL: https://github.com/apache/spark/pull/37931#discussion_r976048121


##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -209,22 +209,6 @@ class SparkThrowableSuite extends SparkFunSuite {
     }
   }
 
-  test("Try catching SparkError with error class") {
-    try {
-      throw new SparkException(
-        errorClass = "WRITING_JOB_ABORTED",

Review Comment:
   we need to keep this test,  but with a different error class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org