[GitHub] [iotdb] wangchao316 commented on a change in pull request #3638: [IOTDB-1484]Auto create schema functionality with e2e testing in cluster

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #3638:
URL: https://github.com/apache/iotdb/pull/3638#discussion_r678907926



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/coordinator/Coordinator.java
##########
@@ -145,7 +145,10 @@ public TSStatus executeNonQueryPlan(PhysicalPlan plan) {
   private TSStatus executeNonQueryLocally(PhysicalPlan plan) {
     boolean execRet;
     try {
-      execRet = metaGroupMember.getLocalExecutor().processNonQuery(plan);
+      if (planExecutor == null) {

Review comment:
       This is the singleton mode, and the concurrency problem needs to be considered.

##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/applier/SingleReplicaApplier.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.cluster.log.applier;
+
+import org.apache.iotdb.cluster.log.Log;
+import org.apache.iotdb.cluster.server.member.DataGroupMember;
+import org.apache.iotdb.cluster.server.member.MetaGroupMember;
+import org.apache.iotdb.db.exception.StorageEngineException;
+import org.apache.iotdb.db.exception.metadata.StorageGroupNotSetException;
+import org.apache.iotdb.db.exception.query.QueryProcessException;
+import org.apache.iotdb.db.qp.physical.PhysicalPlan;
+import org.apache.iotdb.db.qp.physical.crud.*;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SingleReplicaApplier extends DataLogApplier {

Review comment:
       why this replica applier ?  could you please say reason?  thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org