You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/03/25 08:42:22 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #763: [#762] If the storage path is not exist, get file store for its parent.
xianjingfeng opened a new pull request, #763:
URL: https://github.com/apache/incubator-uniffle/pull/763
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
If the storage path is not exist, get file store for its parent.
### Why are the changes needed?
Fix: #762
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #763: [#762] If the storage path is not exist, get file store for its parent.
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #763:
URL: https://github.com/apache/incubator-uniffle/pull/763#issuecomment-1483829420
@xianjingfeng thanks for your work. The exception shall not be thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #763: [#762] If the storage path is not exist, get file store for its parent.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #763:
URL: https://github.com/apache/incubator-uniffle/pull/763#issuecomment-1483769843
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#763](https://codecov.io/gh/apache/incubator-uniffle/pull/763?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd16587) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/567872b8c89a19c16e31c7919ab196fe7568c02a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567872b) will **increase** coverage by `1.16%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #763 +/- ##
============================================
+ Coverage 60.67% 61.84% +1.16%
+ Complexity 1901 1799 -102
============================================
Files 239 214 -25
Lines 13031 10454 -2577
Branches 1091 1044 -47
============================================
- Hits 7907 6465 -1442
+ Misses 4686 3629 -1057
+ Partials 438 360 -78
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...le/storage/common/DefaultStorageMediaProvider.java](https://codecov.io/gh/apache/incubator-uniffle/pull/763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9EZWZhdWx0U3RvcmFnZU1lZGlhUHJvdmlkZXIuamF2YQ==) | `77.50% <100.00%> (+16.89%)` | :arrow_up: |
... and [26 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/763/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng merged pull request #763: [#762] If the storage path is not exist, get file store for its parent.
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng merged PR #763:
URL: https://github.com/apache/incubator-uniffle/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org