You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/10 07:59:55 UTC
[GitHub] [hudi] xushiyan opened a new pull request #2426: [HUDI-304] Configure spotless and java style
xushiyan opened a new pull request #2426:
URL: https://github.com/apache/hudi/pull/2426
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-760076561
@vinothchandar The style can be sync'ed by
- using google-java-format in spotless config and `spotless:apply` enforces the style that is also compatible with existing checkstyle test
- IDE install google-java-format plugin to control the formatter to use the same style
I committed 2 java files to show the diffs. The total diff will be huge, which can be solved by adding `.git-blame-ignore-revs` to ignore the formatting commits. Do the new style and the plan look good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan removed a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan removed a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757438915
## TODO
- [ ] Manually verify some diffs after spotless apply won't conflict with IDE formatter and checkstyle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757443274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#discussion_r554531429
##########
File path: pom.xml
##########
@@ -198,34 +200,36 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
+ <ratchetFrom>origin/master</ratchetFrom>
Review comment:
limit format enforcement to just the files changed by a PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757443274
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=h1) Report
> Merging [#2426](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=desc) (9cb1268) into [master](https://codecov.io/gh/apache/hudi/commit/e926c1a45ca95fa1911f6f88a0577554f2797760?el=desc) (e926c1a) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2426 +/- ##
============================================
- Coverage 50.73% 50.52% -0.21%
+ Complexity 3064 3032 -32
============================================
Files 419 417 -2
Lines 18797 18725 -72
Branches 1922 1917 -5
============================================
- Hits 9536 9461 -75
- Misses 8485 8489 +4
+ Partials 776 775 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `37.28% <ø> (+0.01%)` | `0.00 <ø> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.61% <ø> (-0.41%)` | `0.00 <ø> (ø)` | |
| hudiflink | `10.20% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.00% <ø> (-0.06%)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `66.07% <ø> (+0.16%)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.84% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.41% <ø> (-0.02%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/engine/TaskContextSupplier.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9UYXNrQ29udGV4dFN1cHBsaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/hudi/metadata/FileSystemBackedTableMetadata.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvRmlsZVN5c3RlbUJhY2tlZFRhYmxlTWV0YWRhdGEuamF2YQ==) | `0.00% <0.00%> (-94.60%)` | `0.00% <0.00%> (-13.00%)` | |
| [...apache/hudi/common/engine/HoodieEngineContext.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9Ib29kaWVFbmdpbmVDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/apache/hudi/common/function/FunctionWrapper.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Z1bmN0aW9uL0Z1bmN0aW9uV3JhcHBlci5qYXZh) | `0.00% <0.00%> (-10.53%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `79.31% <0.00%> (-10.35%)` | `15.00% <0.00%> (-1.00%)` | |
| [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | `45.71% <0.00%> (-6.18%)` | `55.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/common/table/HoodieTableMetaClient.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL0hvb2RpZVRhYmxlTWV0YUNsaWVudC5qYXZh) | `68.96% <0.00%> (-1.73%)` | `43.00% <0.00%> (-2.00%)` | |
| [...i/common/table/timeline/TimelineMetadataUtils.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL1RpbWVsaW5lTWV0YWRhdGFVdGlscy5qYXZh) | `71.69% <0.00%> (-1.03%)` | `17.00% <0.00%> (ø%)` | |
| [...rg/apache/hudi/hadoop/HoodieROTablePathFilter.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZVJPVGFibGVQYXRoRmlsdGVyLmphdmE=) | `63.15% <0.00%> (-0.48%)` | `12.00% <0.00%> (ø%)` | |
| [...ava/org/apache/hudi/common/HoodieRollbackStat.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL0hvb2RpZVJvbGxiYWNrU3RhdC5qYXZh) | `31.25% <0.00%> (-0.33%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910862643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757443274
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=h1) Report
> Merging [#2426](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=desc) (9cb1268) into [master](https://codecov.io/gh/apache/hudi/commit/23e93d05c02775b0c518a2da160810b23bb4bca4?el=desc) (23e93d0) will **decrease** coverage by `40.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2426 +/- ##
============================================
- Coverage 50.54% 9.64% -40.90%
+ Complexity 3033 48 -2985
============================================
Files 417 53 -364
Lines 18725 1929 -16796
Branches 1917 230 -1687
============================================
- Hits 9464 186 -9278
+ Misses 8488 1730 -6758
+ Partials 773 13 -760
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `?` | `?` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `9.64% <ø> (-59.83%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/hudi/utilities/sources/CsvDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQ3N2REZTU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/apache/hudi/utilities/sources/JsonDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkRGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...apache/hudi/utilities/sources/JsonKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkthZmthU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/utilities/sources/ParquetDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUGFycXVldERGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lities/schema/SchemaProviderWithPostProcessor.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlcldpdGhQb3N0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [394 more](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-961587546
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910862643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757443274
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=h1) Report
> Merging [#2426](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=desc) (9cb1268) into [master](https://codecov.io/gh/apache/hudi/commit/23e93d05c02775b0c518a2da160810b23bb4bca4?el=desc) (23e93d0) will **decrease** coverage by `40.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2426 +/- ##
============================================
- Coverage 50.54% 9.64% -40.90%
+ Complexity 3033 48 -2985
============================================
Files 417 53 -364
Lines 18725 1929 -16796
Branches 1917 230 -1687
============================================
- Hits 9464 186 -9278
+ Misses 8488 1730 -6758
+ Partials 773 13 -760
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `9.64% <ø> (-59.83%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/hudi/utilities/sources/CsvDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQ3N2REZTU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/apache/hudi/utilities/sources/JsonDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkRGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...apache/hudi/utilities/sources/JsonKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkthZmthU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/utilities/sources/ParquetDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUGFycXVldERGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lities/schema/SchemaProviderWithPostProcessor.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlcldpdGhQb3N0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [394 more](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757443274
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=h1) Report
> Merging [#2426](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=desc) (9cb1268) into [master](https://codecov.io/gh/apache/hudi/commit/e926c1a45ca95fa1911f6f88a0577554f2797760?el=desc) (e926c1a) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2426 +/- ##
============================================
- Coverage 50.73% 50.52% -0.21%
+ Complexity 3064 3032 -32
============================================
Files 419 417 -2
Lines 18797 18725 -72
Branches 1922 1917 -5
============================================
- Hits 9536 9461 -75
- Misses 8485 8489 +4
+ Partials 776 775 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `37.28% <ø> (+0.01%)` | `0.00 <ø> (ø)` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `51.61% <ø> (-0.41%)` | `0.00 <ø> (ø)` | |
| hudiflink | `10.20% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudihadoopmr | `33.00% <ø> (-0.06%)` | `0.00 <ø> (ø)` | |
| hudisparkdatasource | `66.07% <ø> (+0.16%)` | `0.00 <ø> (ø)` | |
| hudisync | `48.61% <ø> (ø)` | `0.00 <ø> (ø)` | |
| huditimelineservice | `66.84% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudiutilities | `69.41% <ø> (-0.02%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2426?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/engine/TaskContextSupplier.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9UYXNrQ29udGV4dFN1cHBsaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/hudi/metadata/FileSystemBackedTableMetadata.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvRmlsZVN5c3RlbUJhY2tlZFRhYmxlTWV0YWRhdGEuamF2YQ==) | `0.00% <0.00%> (-94.60%)` | `0.00% <0.00%> (-13.00%)` | |
| [...apache/hudi/common/engine/HoodieEngineContext.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2VuZ2luZS9Ib29kaWVFbmdpbmVDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/apache/hudi/common/function/FunctionWrapper.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Z1bmN0aW9uL0Z1bmN0aW9uV3JhcHBlci5qYXZh) | `0.00% <0.00%> (-10.53%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `79.31% <0.00%> (-10.35%)` | `15.00% <0.00%> (-1.00%)` | |
| [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | `45.71% <0.00%> (-6.18%)` | `55.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/common/table/HoodieTableMetaClient.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL0hvb2RpZVRhYmxlTWV0YUNsaWVudC5qYXZh) | `68.96% <0.00%> (-1.73%)` | `43.00% <0.00%> (-2.00%)` | |
| [...i/common/table/timeline/TimelineMetadataUtils.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL1RpbWVsaW5lTWV0YWRhdGFVdGlscy5qYXZh) | `71.69% <0.00%> (-1.03%)` | `17.00% <0.00%> (ø%)` | |
| [...rg/apache/hudi/hadoop/HoodieROTablePathFilter.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZVJPVGFibGVQYXRoRmlsdGVyLmphdmE=) | `63.15% <0.00%> (-0.48%)` | `12.00% <0.00%> (ø%)` | |
| [...ava/org/apache/hudi/common/HoodieRollbackStat.java](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL0hvb2RpZVJvbGxiYWNrU3RhdC5qYXZh) | `31.25% <0.00%> (-0.33%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/hudi/pull/2426/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#discussion_r554531429
##########
File path: pom.xml
##########
@@ -198,34 +200,36 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
+ <ratchetFrom>origin/master</ratchetFrom>
Review comment:
limit format enforcement to just the files changed by a PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan edited a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-760076561
@vinothchandar @leesf @yanghua The style can be sync'ed by
- using google-java-format in spotless config and `spotless:apply` enforces the style that is also compatible with existing checkstyle test
- IDE install google-java-format plugin to control the formatter to use the same style
I committed 2 java files to show the diffs. The total diff will be huge, which can be solved by adding `.git-blame-ignore-revs` to ignore the formatting commits. Do the new style and the plan look good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910861287
@xushiyan we should probably pick this back up sometime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-961587546
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910862643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-757438915
## TODO
- [ ] Manually verify some diffs after spotless apply won't conflict with IDE formatter and checkstyle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#discussion_r562873786
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -18,36 +18,36 @@
package org.apache.hudi.hive;
-import java.io.UnsupportedEncodingException;
-import java.net.URLDecoder;
-import java.nio.charset.StandardCharsets;
-import org.apache.hadoop.hive.metastore.api.FieldSchema;
-import org.apache.hadoop.hive.metastore.api.MetaException;
-import org.apache.hadoop.hive.metastore.api.Partition;
-import org.apache.hadoop.hive.metastore.api.Table;
-import org.apache.hadoop.hive.metastore.api.Database;
import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.fs.StorageSchemes;
import org.apache.hudi.common.table.timeline.HoodieTimeline;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.hive.util.HiveSchemaUtil;
+import org.apache.hudi.sync.common.AbstractSyncHoodieClient;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.Database;
Review comment:
does this organization work consistenty with `Code > Optimize Imports` in IntelliJ? This was the large stick point from last time.
##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -76,12 +76,18 @@
private HiveConf configuration;
public HoodieHiveClient(HiveSyncConfig cfg, HiveConf configuration, FileSystem fs) {
- super(cfg.basePath, cfg.assumeDatePartitioning, cfg.useFileListingFromMetadata, cfg.verifyMetadataFileListing, fs);
+ super(
+ cfg.basePath,
Review comment:
personally, not a great fan of using a full line for each method argument. Where is this style coming from?
I would be happy to concede, but like to understand what style we are picking here.
##########
File path: pom.xml
##########
@@ -198,34 +200,35 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
<java>
- <eclipse>
- <file>${main.basedir}/style/eclipse-java-google-style.xml</file>
- <version>4.10.0</version>
- </eclipse>
- </java>
- <scala>
+ <googleJavaFormat>
Review comment:
what does Flink use? I think it does `AOSP` ? the wraps are lot more nicer, the one arg per line, really makes it hard to get a good chunk of code read in one screen.
##########
File path: pom.xml
##########
@@ -198,34 +200,35 @@
</execution>
</executions>
</plugin>
-<!--
- See https://jira.apache.org/jira/browse/HUDI-304
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
- <version>1.24.3</version>
+ <version>${spotless.version}</version>
<configuration>
<java>
- <eclipse>
- <file>${main.basedir}/style/eclipse-java-google-style.xml</file>
- <version>4.10.0</version>
- </eclipse>
- </java>
- <scala>
+ <googleJavaFormat>
Review comment:
e.g https://github.com/apache/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910862643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #2426: [HUDI-304] Configure spotless and java style
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-961587546
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b7aa291685a1a350fff98607ebcdf0d19ce64f3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org