You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 15:44:50 UTC
[GitHub] [arrow] eitsupi opened a new pull request #12547: MINOR: [R][DOCS] Fix Scalar's reference
eitsupi opened a new pull request #12547:
URL: https://github.com/apache/arrow/pull/12547
- Change to list format like other classes
- Add missing `cast()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#discussion_r817981892
##########
File path: r/R/scalar.R
##########
@@ -25,14 +25,18 @@
#' @description A `Scalar` holds a single value of an Arrow type.
#'
#' @section Methods:
-#' `$ToString()`: convert to a string
-#' `$as_vector()`: convert to an R vector
-#' `$as_array()`: convert to an Arrow `Array`
-#' `$Equals(other)`: is this Scalar equal to `other`
-#' `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
-#' `$is_valid`: is this Scalar valid
-#' `$null_count`: number of invalid values - 1 or 0
-#' `$type`: Scalar type
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#issuecomment-1057260128
Benchmark runs are scheduled for baseline = 68709af8f62f4712f1d64e17e65b38b10284cf85 and contender = 6e30184fbd2aab02b7581eabdadcfe7ea62b319f. 6e30184fbd2aab02b7581eabdadcfe7ea62b319f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6245eba5ecf4f818b93696950e1cb61...b5aa637f04c7475f857e4d913026a879/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2224856c001c4579b0dbb66c2d1c0034...3fd21b376e3d447bb59d011ee6386539/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd3554edbec644d983a610d3eac6cbf1...40c058f77b8d4e348160e4a9c6167d15/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ca68063e5842029e0bb1c30e7c9f96...bbbae665e36a4a7690ac6cfb2d291de0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#issuecomment-1057260128
Benchmark runs are scheduled for baseline = 68709af8f62f4712f1d64e17e65b38b10284cf85 and contender = 6e30184fbd2aab02b7581eabdadcfe7ea62b319f. 6e30184fbd2aab02b7581eabdadcfe7ea62b319f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6245eba5ecf4f818b93696950e1cb61...b5aa637f04c7475f857e4d913026a879/)
[Finished :arrow_down:0.38% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2224856c001c4579b0dbb66c2d1c0034...3fd21b376e3d447bb59d011ee6386539/)
[Finished :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd3554edbec644d983a610d3eac6cbf1...40c058f77b8d4e348160e4a9c6167d15/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ca68063e5842029e0bb1c30e7c9f96...bbbae665e36a4a7690ac6cfb2d291de0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#discussion_r817981088
##########
File path: r/R/scalar.R
##########
@@ -25,14 +25,16 @@
#' @description A `Scalar` holds a single value of an Arrow type.
#'
#' @section Methods:
-#' `$ToString()`: convert to a string
-#' `$as_vector()`: convert to an R vector
-#' `$as_array()`: convert to an Arrow `Array`
-#' `$Equals(other)`: is this Scalar equal to `other`
-#' `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
-#' `$is_valid`: is this Scalar valid
-#' `$null_count`: number of invalid values - 1 or 0
-#' `$type`: Scalar type
+#' - `$ToString()`: convert to a string
Review comment:
```suggestion
#' - `$ToString()`: convert to a string
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#issuecomment-1057260128
Benchmark runs are scheduled for baseline = 68709af8f62f4712f1d64e17e65b38b10284cf85 and contender = 6e30184fbd2aab02b7581eabdadcfe7ea62b319f. 6e30184fbd2aab02b7581eabdadcfe7ea62b319f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6245eba5ecf4f818b93696950e1cb61...b5aa637f04c7475f857e4d913026a879/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2224856c001c4579b0dbb66c2d1c0034...3fd21b376e3d447bb59d011ee6386539/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd3554edbec644d983a610d3eac6cbf1...40c058f77b8d4e348160e4a9c6167d15/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ca68063e5842029e0bb1c30e7c9f96...bbbae665e36a4a7690ac6cfb2d291de0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#issuecomment-1057260128
Benchmark runs are scheduled for baseline = 68709af8f62f4712f1d64e17e65b38b10284cf85 and contender = 6e30184fbd2aab02b7581eabdadcfe7ea62b319f. 6e30184fbd2aab02b7581eabdadcfe7ea62b319f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6245eba5ecf4f818b93696950e1cb61...b5aa637f04c7475f857e4d913026a879/)
[Finished :arrow_down:0.38% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2224856c001c4579b0dbb66c2d1c0034...3fd21b376e3d447bb59d011ee6386539/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd3554edbec644d983a610d3eac6cbf1...40c058f77b8d4e348160e4a9c6167d15/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ca68063e5842029e0bb1c30e7c9f96...bbbae665e36a4a7690ac6cfb2d291de0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #12547:
URL: https://github.com/apache/arrow/pull/12547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#issuecomment-1057260128
Benchmark runs are scheduled for baseline = 68709af8f62f4712f1d64e17e65b38b10284cf85 and contender = 6e30184fbd2aab02b7581eabdadcfe7ea62b319f. 6e30184fbd2aab02b7581eabdadcfe7ea62b319f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6245eba5ecf4f818b93696950e1cb61...b5aa637f04c7475f857e4d913026a879/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2224856c001c4579b0dbb66c2d1c0034...3fd21b376e3d447bb59d011ee6386539/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd3554edbec644d983a610d3eac6cbf1...40c058f77b8d4e348160e4a9c6167d15/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ca68063e5842029e0bb1c30e7c9f96...bbbae665e36a4a7690ac6cfb2d291de0/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#discussion_r817981088
##########
File path: r/R/scalar.R
##########
@@ -25,14 +25,16 @@
#' @description A `Scalar` holds a single value of an Arrow type.
#'
#' @section Methods:
-#' `$ToString()`: convert to a string
-#' `$as_vector()`: convert to an R vector
-#' `$as_array()`: convert to an Arrow `Array`
-#' `$Equals(other)`: is this Scalar equal to `other`
-#' `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
-#' `$is_valid`: is this Scalar valid
-#' `$null_count`: number of invalid values - 1 or 0
-#' `$type`: Scalar type
+#' - `$ToString()`: convert to a string
Review comment:
```suggestion
#'
#' - `$ToString()`: convert to a string
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#discussion_r817979160
##########
File path: r/R/scalar.R
##########
@@ -25,14 +25,16 @@
#' @description A `Scalar` holds a single value of an Arrow type.
#'
#' @section Methods:
-#' `$ToString()`: convert to a string
-#' `$as_vector()`: convert to an R vector
-#' `$as_array()`: convert to an Arrow `Array`
-#' `$Equals(other)`: is this Scalar equal to `other`
-#' `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
-#' `$is_valid`: is this Scalar valid
-#' `$null_count`: number of invalid values - 1 or 0
-#' `$type`: Scalar type
+#' - `$ToString()`: convert to a string
+#' - `$as_vector()`: convert to an R vector
+#' - `$as_array()`: convert to an Arrow `Array`
+#' - `$Equals(other)`: is this Scalar equal to `other`
+#' - `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
+#' - `$is_valid`: is this Scalar valid
+#' - `$null_count`: number of invalid values - 1 or 0
+#' - `$type`: Scalar type
+#' - `$cast(target_type, safe = TRUE, options = cast_options(safe))`: Alter the
+#' data in the Scalar to change its type.
Review comment:
```suggestion
#' - `$cast(target_type, safe = TRUE, options = cast_options(safe))`: cast value
#' to a different type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12547: MINOR: [R][DOCS] Fix Scalar reference
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12547:
URL: https://github.com/apache/arrow/pull/12547#discussion_r817979160
##########
File path: r/R/scalar.R
##########
@@ -25,14 +25,16 @@
#' @description A `Scalar` holds a single value of an Arrow type.
#'
#' @section Methods:
-#' `$ToString()`: convert to a string
-#' `$as_vector()`: convert to an R vector
-#' `$as_array()`: convert to an Arrow `Array`
-#' `$Equals(other)`: is this Scalar equal to `other`
-#' `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
-#' `$is_valid`: is this Scalar valid
-#' `$null_count`: number of invalid values - 1 or 0
-#' `$type`: Scalar type
+#' - `$ToString()`: convert to a string
+#' - `$as_vector()`: convert to an R vector
+#' - `$as_array()`: convert to an Arrow `Array`
+#' - `$Equals(other)`: is this Scalar equal to `other`
+#' - `$ApproxEquals(other)`: is this Scalar approximately equal to `other`
+#' - `$is_valid`: is this Scalar valid
+#' - `$null_count`: number of invalid values - 1 or 0
+#' - `$type`: Scalar type
+#' - `$cast(target_type, safe = TRUE, options = cast_options(safe))`: Alter the
+#' data in the Scalar to change its type.
Review comment:
```suggestion
#' - `$cast(target_type, safe = TRUE, options = cast_options(safe))`: cast value to a different type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org