You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2023/01/12 16:10:00 UTC
[jira] [Comment Edited] (SLING-11736) Create path should potentially adjust the primary type/mixin types of existing nodes
[ https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656507#comment-17656507 ]
Konrad Windszus edited comment on SLING-11736 at 1/12/23 4:09 PM:
------------------------------------------------------------------
Added the new statement in the parser in https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/9d7d66aaf244d149124fd491dddf6b90e0172efb.
Implemented it in https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/abb28aa77f215f53d4dfa01b4de6d3dd233f20a1.
was (Author: kwin):
Added the new statement in https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/9d7d66aaf244d149124fd491dddf6b90e0172efb.
> Create path should potentially adjust the primary type/mixin types of existing nodes
> ------------------------------------------------------------------------------------
>
> Key: SLING-11736
> URL: https://issues.apache.org/jira/browse/SLING-11736
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
> Affects Versions: Repoinit JCR 1.1.42
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: Repoinit Parser 1.8.2, Repoinit JCR 1.1.44
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Currently "create path ...." is a no-op when the path does already exist (https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/9913b787574186a7a31d184480cec3862816438f/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L191). This is dangerous as then the path might have other primary and mixin types and subsequent calls of "set properties ..." might fail.
> Instead the primary type and mixins should potentially be adjusted on existing nodes as well.
> This happened in https://github.com/adobe/aem-project-archetype/issues/997#issuecomment-1351895791 which lead to not starting the repository at all.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)