You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/03/22 13:54:04 UTC
[GitHub] [groovy] danielsun1106 commented on a change in pull request #1202:
Refactor of some groovy methods
danielsun1106 commented on a change in pull request #1202: Refactor of some groovy methods
URL: https://github.com/apache/groovy/pull/1202#discussion_r396093584
##########
File path: src/main/java/groovy/util/GroovyCollections.java
##########
@@ -18,16 +18,19 @@
*/
package groovy.util;
+import org.codehaus.groovy.runtime.ArrayUtil;
import org.codehaus.groovy.runtime.DefaultGroovyMethods;
import org.codehaus.groovy.runtime.ScriptBytecodeAdapter;
import org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
Review comment:
We prefer importing qualified classes and avoid using `*`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services