You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 14:08:50 UTC
[GitHub] [airflow] raphaelauv opened a new pull request, #24445: rename GKEStartPodOperator -> GKEPodOperator
raphaelauv opened a new pull request, #24445:
URL: https://github.com/apache/airflow/pull/24445
KubernetesPodOperator
EksPodOperator
GKEStartPodOperator
we could fix this inconsistency by renaming GKEStartPodOperator -> GKEPodOperator or even GkePodOperator ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1270873428
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24445: rename KubernetesPodOperator -> KubernetesRunPodOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1205378808
> GKEStartPodOperator -> GKEPodOperator
>
> @potiuk ?
Sounds much better :) - but I woudl love to hear what others say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #24445: rename KubernetesPodOperator -> KubernetesRunPodOperator
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1205364657
then only rename
GKEStartPodOperator -> GKEPodOperator
@potiuk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1155637135
KubernetesRunPodOperator sound good to me, but we should discuss it in a wider group, because it is one of the most popular operators. Can you create a thread on mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24445: rename KubernetesPodOperator -> KubernetesRunPodOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1205361105
Are we sure we want to get here? KPO is such a comnmon name, and such ubiquitous all over the place that I am hesitating quite a bit to renaming it. KRPO sounds already pretty bad.
In this case I am not sure if consistency is a king any more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1221635462
Still some errors :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1155259222
We used to have discussions about operator naming and agreed that every operator should have a verb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1155269746
Discussion thread: https://lists.apache.org/thread/6k9jzrd2jzsmz073m68b49zz2zhlzhfv
> I think that the operator should describe the behavior(verb), hook should
> describe a service(noun). These are other parts of speech.
> In my opinion, HiveOperator should be named HiveExecuteQuery. Hook will be
> called Hive. Then there will be no name conflicts.
> But I do like the verb/noun idea. That's a really nice way of thinking about what belongs where.
> I completely agree that the operator names have been a bit muddled,
HiveExecuteQuery sounds better to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1155293154
Then GKEStartPodOperator is not doing what it say
cause the GKEStartPodOperator is not only starting a pod , but it's starting , tracking and waiting for end of the pod (and also re-attach)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
URL: https://github.com/apache/airflow/pull/24445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24445: rename GKEStartPodOperator -> GKERunPodOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1200317724
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1155295293
So a better name could be KubernetesRunPodOperator ? GkeRunPodOperator ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24445: rename GKEStartPodOperator -> GKEPodOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24445:
URL: https://github.com/apache/airflow/pull/24445#issuecomment-1206686174
Failures :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org