You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/09 03:13:17 UTC

[GitHub] [dubbo-go] peaman opened a new pull request #858: enhancement: custom registry report ip and ports

peaman opened a new pull request #858:
URL: https://github.com/apache/dubbo-go/pull/858


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. 
   -->
   
   **What this PR does**:
   support custom report to registry ip and port from environment variables. like apache/dubbo
   
   **Which issue(s) this PR fixes**:
   None
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   
   **Special notes for your reviewer**:
   the code is simple. please the code style is right?
   
   **Does this PR introduce a user-facing change?**:
   Now the user can specify  the IP and port what report to registry  by set environment variables.
   
   DUBBOGO_IP_TO_REGISTRY -> custom IP
   DUBBOGO_PORT_TO_REGISTRY -> custom port
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on pull request #858: enhancement: custom registry report ip and ports

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #858:
URL: https://github.com/apache/dubbo-go/pull/858#issuecomment-723754989


   @peaman  Pls refer to https://developer.aliyun.com/article/777450 Depart 5.2 and get the method how to transfer param by your own code in your app. If this article can not give u some inspiration, then let's talk about this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] peaman closed pull request #858: enhancement: custom registry report ip and ports

Posted by GitBox <gi...@apache.org>.
peaman closed pull request #858:
URL: https://github.com/apache/dubbo-go/pull/858


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org