You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2024/03/26 17:03:15 UTC
[PR] GH-40719: [Go] Make `arrow.Null` non-null for `arrow.TypeEqual` to work properly with `new(arrow.NullType)` [arrow]
candiduslynx opened a new pull request, #40802:
URL: https://github.com/apache/arrow/pull/40802
### Rationale for this change
Currently creating a record with a `null` type via `new(arrow.NullType)` in the schema will fail the schema validation.
### What changes are included in this PR?
Made `arrow.Null` a non-null value instead of just a declaration.
### Are these changes tested?
If that's required, could you suggest a good test and/or a place to put the test?
I suppose, adding a `null` type to `NewRecord` test case might just work.
### Are there any user-facing changes?
`arrow.Null` became non-null, but the type is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40719: [Go] Make `arrow.Null` non-null for `arrow.TypeEqual` to work properly with `new(arrow.NullType)` [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #40802:
URL: https://github.com/apache/arrow/pull/40802#issuecomment-2021241285
@candiduslynx can you add a small test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40719: [Go] Make `arrow.Null` non-null for `arrow.TypeEqual` to work properly with `new(arrow.NullType)` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40802:
URL: https://github.com/apache/arrow/pull/40802#issuecomment-2022590253
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f710ac52b049806515a14445b242c3ec819fb99d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23149362422) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40719: [Go] Make `arrow.Null` non-null for `arrow.TypeEqual` to work properly with `new(arrow.NullType)` [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #40802:
URL: https://github.com/apache/arrow/pull/40802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40719: [Go] Make `arrow.Null` non-null for `arrow.TypeEqual` to work properly with `new(arrow.NullType)` [arrow]
Posted by "candiduslynx (via GitHub)" <gi...@apache.org>.
candiduslynx commented on PR #40802:
URL: https://github.com/apache/arrow/pull/40802#issuecomment-2021268483
> @candiduslynx can you add a small test for this?
cd4253a24e6d828128fbb7854da3c37951d74885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org