You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/24 04:38:36 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #12168: fix logger number not correct in tests
Shoothzj opened a new pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168
### Motivation
Log placehodlers not correct. Cause some log info is missing or `{}` alone
### Modifications
Fix the placeholder, add `{}` or delete `{}`
### Documentation
- [ ] no-need-doc
this is an internal optimize, don't need doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a change in pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#discussion_r715344300
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
}
} catch (Exception e) {
- log.warn("Unable to fetch read-only policy config {}", e);
+ log.warn("Unable to fetch read-only policy config ", e);
Review comment:
Yes, I don't paas a placeholder, I am deleteing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#issuecomment-926400340
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#discussion_r715453239
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
}
} catch (Exception e) {
- log.warn("Unable to fetch read-only policy config {}", e);
+ log.warn("Unable to fetch read-only policy config ", e);
Review comment:
Oh sorry. I need a coffee.
I misread the diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#discussion_r715341908
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
}
} catch (Exception e) {
- log.warn("Unable to fetch read-only policy config {}", e);
+ log.warn("Unable to fetch read-only policy config ", e);
Review comment:
In slf4j you don't need to pass a placeholder for exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#issuecomment-926468674
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#issuecomment-926450714
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #12168: fix logger number not correct in tests
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#discussion_r715706532
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
}
} catch (Exception e) {
- log.warn("Unable to fetch read-only policy config {}", e);
+ log.warn("Unable to fetch read-only policy config ", e);
Review comment:
Though the behavior with or without placeholder is different, and in some cases we really mean to have the placeholder there. eg:
* With placeholder: only the exception message is printed
* Without placeholder: the full stacks trace is printed
For common, expected errors we don't want to pollute the logs with lots of stack traces that are not very useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org