You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Adam Kocoloski (JIRA)" <ji...@apache.org> on 2011/01/28 21:58:44 UTC
[jira] Created: (COUCHDB-1049) Etap tests should not require port
5984
Etap tests should not require port 5984
---------------------------------------
Key: COUCHDB-1049
URL: https://issues.apache.org/jira/browse/COUCHDB-1049
Project: CouchDB
Issue Type: Bug
Reporter: Adam Kocoloski
Fix For: 1.0.3, 1.1
In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989785#comment-12989785 ]
Paul Joseph Davis commented on COUCHDB-1049:
--------------------------------------------
Trickery!
Though that should also depend on setting the port to 0 in the config file, which, near as I can tell, you only do for the http proxy tests. Did you mean to add a third ini file to override that in test_utils:config_files()?
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989782#comment-12989782 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Ah, yeah, that's mochiweb_socket_server:get(couch_httpd, port), which relies on a cached result of inet:port(Socket) underneath.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989792#comment-12989792 ]
Paul Joseph Davis commented on COUCHDB-1049:
--------------------------------------------
Moar trickery!
LGTM
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989778#comment-12989778 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Oh, whoops! Missed your message Paul. I figured this one didn't need too much review since it's only touching test code. By the way, this link gives a decent compare:
https://github.com/kocolosk/couchdb/compare/1049-etap-httpd-ports
since it uses apache:trunk as the default. I don't know why rnewson's patch is on there, probably because it's picked from his git branch instead of the git-svn version.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989757#comment-12989757 ]
Paul Joseph Davis commented on COUCHDB-1049:
--------------------------------------------
Can i get a compare view link for that branch?
https://github.com/kocolosk/couchdb/compare/trunk...1049-etap-httpd-ports
Looks like you haven't pushed to trunk in awhile.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988231#action_12988231 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Here's a patch:
https://github.com/kocolosk/couchdb/tree/1049-etap-httpd-ports
The only limitation is that 180-http-proxy.t will fail if something is running on 5985 or 5986.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989712#comment-12989712 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Updated the branch with a patch that runs the _test resource on a random port and tries to connect to an IANA reserved port for the _error resource.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989737#comment-12989737 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Added another patch. Now the server always listens on an unused port during the etap unit tests, so there's no chance of eaddrinuse collisions with other instances of CouchDB.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski closed COUCHDB-1049.
-----------------------------------
Resolution: Fixed
Assignee: Adam Kocoloski
Unit tests fire up a couch on a random port now.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989781#comment-12989781 ]
Paul Joseph Davis commented on COUCHDB-1049:
--------------------------------------------
Heh, no biggy. When I saw your comment about the extra patch I thought you meant take a peek. I'm sure its fine I was mostly just curious to see how you fixed the random port generation.
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989771#comment-12989771 ]
Paul Joseph Davis commented on COUCHDB-1049:
--------------------------------------------
That's one way to get a compare view. XD
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-1049) Etap tests should not require port
5984
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989791#comment-12989791 ]
Adam Kocoloski commented on COUCHDB-1049:
-----------------------------------------
Yep, in the final version I believe that's exactly what I did:
http://svn.apache.org/viewvc/couchdb/trunk/test/etap/test_util.erl.in?r1=1066574&r2=1066573&pathrev=1066574
A call to test_util:config_files() pulls in random_port.ini, which sets [httpd] port = 0
> Etap tests should not require port 5984
> ---------------------------------------
>
> Key: COUCHDB-1049
> URL: https://issues.apache.org/jira/browse/COUCHDB-1049
> Project: CouchDB
> Issue Type: Bug
> Reporter: Adam Kocoloski
> Assignee: Adam Kocoloski
> Fix For: 1.0.3, 1.1
>
>
> In fact, perhaps they should run somewhere else by default.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira