You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2023/06/07 14:36:12 UTC
[GitHub] [ozone] sodonnel commented on a diff in pull request #4841: HDDS-8776. ReplicationManager: Log overloaded commands at debug rather than error level
sodonnel commented on code in PR #4841:
URL: https://github.com/apache/ozone/pull/4841#discussion_r1221714750
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnhealthyReplicationProcessor.java:
##########
@@ -117,19 +114,27 @@ public void processAll(ReplicationQueue queue) {
healthStateCntMap.compute(healthResult.getHealthState(),
(healthState, cnt) -> cnt == null ? 1 : (cnt + 1));
} catch (Exception e) {
- LOG.error("Error processing Health result of class: {} for " +
- "container {}", healthResult.getClass(),
- healthResult.getContainerInfo(), e);
- failed++;
+ if (e instanceof CommandTargetOverloadedException) {
+ LOG.debug("All targets overloaded when processing Health result of " +
+ "class: {} for container {}", healthResult.getClass(),
+ healthResult.getContainerInfo(), e);
Review Comment:
I wasn't sure if we should or not. For now I have removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org