You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2019/11/16 02:06:00 UTC
[jira] [Commented] (HBASE-23038) Provide consistent and clear
logging about disabling chores
[ https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975527#comment-16975527 ]
Hudson commented on HBASE-23038:
--------------------------------
Results for branch branch-2.2
[build #694 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide consistent and clear logging about disabling chores
> -----------------------------------------------------------
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Reporter: Sean Busbey
> Assignee: Sanjeet Nishad
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch, HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager] master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager] hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which submits to a java ScheduledExecutorService and then catches the IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period before accepting a submittal and produces a consistent "Foo is disabled" message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)