You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/06/07 00:02:15 UTC
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3322
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
---
M www/bootstrap/css/bootstrap-theme.css
M www/bootstrap/css/bootstrap-theme.css.map
M www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
M www/bootstrap/fonts/glyphicons-halflings-regular.eot
M www/bootstrap/fonts/glyphicons-halflings-regular.svg
M www/bootstrap/fonts/glyphicons-halflings-regular.ttf
M www/bootstrap/fonts/glyphicons-halflings-regular.woff
A www/bootstrap/fonts/glyphicons-halflings-regular.woff2
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
A www/bootstrap/js/npm.js
A www/jquery/jquery-1.12.4.min.js
17 files changed, 4,716 insertions(+), 3,011 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/22/3322/1
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Reviewed-on: http://gerrit.cloudera.org:8080/3322
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Henry Robinson <he...@cloudera.com>
---
M www/bootstrap/css/bootstrap-theme.css
M www/bootstrap/css/bootstrap-theme.css.map
M www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
M www/bootstrap/fonts/glyphicons-halflings-regular.eot
M www/bootstrap/fonts/glyphicons-halflings-regular.svg
M www/bootstrap/fonts/glyphicons-halflings-regular.ttf
M www/bootstrap/fonts/glyphicons-halflings-regular.woff
A www/bootstrap/fonts/glyphicons-halflings-regular.woff2
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
A www/bootstrap/js/npm.js
A www/jquery/jquery-1.12.4.min.js
17 files changed, 4,716 insertions(+), 3,011 deletions(-)
Approvals:
Henry Robinson: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Patch Set 1: Code-Review+2
Seems fine to me.
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Patch Set 1: Code-Review+1
Downloaded the jquery and bootstrap libs locally and ran a diff to make sure the contents in the patch and my local download are same. LGTM
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Patch Set 2: Verified+1
Verified by http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/2342/
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Add JQuery 1.12.4, upgrade Bootstrap to 3.3.6
......................................................................
Patch Set 2: Code-Review+2
Carrying on +2, running a private job to get this in (nothing should change).
--
To view, visit http://gerrit.cloudera.org:8080/3322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6427a4ce7cb606a03cf7e4e5c4250a845fc2145
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No