You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2023/07/03 08:39:33 UTC
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1223: [format] support parquet filter push down for paimon
JingsongLi commented on code in PR #1223:
URL: https://github.com/apache/incubator-paimon/pull/1223#discussion_r1250491957
##########
paimon-format/src/test/java/org/apache/paimon/format/parquet/filter/ParquetFilterConverterTest.java:
##########
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.format.parquet.filter;
+
+import org.apache.paimon.data.Decimal;
+import org.apache.paimon.predicate.Predicate;
+import org.apache.paimon.predicate.PredicateBuilder;
+import org.apache.paimon.types.ArrayType;
+import org.apache.paimon.types.BigIntType;
+import org.apache.paimon.types.BinaryType;
+import org.apache.paimon.types.BooleanType;
+import org.apache.paimon.types.CharType;
+import org.apache.paimon.types.DataField;
+import org.apache.paimon.types.DataType;
+import org.apache.paimon.types.DateType;
+import org.apache.paimon.types.DecimalType;
+import org.apache.paimon.types.DoubleType;
+import org.apache.paimon.types.FloatType;
+import org.apache.paimon.types.IntType;
+import org.apache.paimon.types.MapType;
+import org.apache.paimon.types.MultisetType;
+import org.apache.paimon.types.RowType;
+import org.apache.paimon.types.TimeType;
+import org.apache.paimon.types.TimestampType;
+import org.apache.paimon.types.VarBinaryType;
+import org.apache.paimon.types.VarCharType;
+
+import org.apache.parquet.io.api.Binary;
+import org.assertj.core.util.Lists;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.io.Serializable;
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Optional;
+import java.util.stream.Collectors;
+import java.util.stream.LongStream;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Unit Tests for {@link ParquetPredicateFunctionVisitor}. */
+public class ParquetFilterConverterTest {
+ @Test
+ public void testApplyCompoundPredicate() {
+ PredicateBuilder builder =
+ new PredicateBuilder(
+ new RowType(
+ Collections.singletonList(
+ new DataField(0, "fieldName", new BigIntType()))));
+
+ test(
+ builder.in(0, Arrays.asList(1L, 2L, 3L)),
+ new ParquetFilters.Or(
+ new ParquetFilters.Or(
+ new ParquetFilters.Equals("fieldName", new BigIntType(), 1),
+ new ParquetFilters.Equals("fieldName", new BigIntType(), 2)),
+ new ParquetFilters.Equals("fieldName", new BigIntType(), 3)),
+ true);
+
+ test(
+ builder.between(0, 1L, 3L),
+ new ParquetFilters.And(
+ new ParquetFilters.Not(
+ new ParquetFilters.LessThan("fieldName", new BigIntType(), 1)),
+ new ParquetFilters.LessThanEquals("fieldName", new BigIntType(), 3)),
+ true);
+
+ test(
+ builder.notIn(0, Arrays.asList(1L, 2L, 3L)),
+ new ParquetFilters.And(
+ new ParquetFilters.And(
+ new ParquetFilters.Not(
+ new ParquetFilters.Equals(
+ "fieldName", new BigIntType(), 1)),
+ new ParquetFilters.Not(
+ new ParquetFilters.Equals(
+ "fieldName", new BigIntType(), 2))),
+ new ParquetFilters.Not(
+ new ParquetFilters.Equals("fieldName", new BigIntType(), 3))),
+ true);
+
+ assertThat(
+ builder.in(
+ 0,
+ LongStream.range(1L, 22L)
+ .boxed()
+ .collect(Collectors.toList()))
+ .visit(ParquetPredicateFunctionVisitor.VISITOR)
+ .isPresent())
+ .isFalse();
+
+ assertThat(
+ builder.notIn(
+ 0,
+ LongStream.range(1L, 22L)
+ .boxed()
+ .collect(Collectors.toList()))
+ .visit(ParquetPredicateFunctionVisitor.VISITOR)
+ .isPresent())
+ .isFalse();
+ }
+
+ @ParameterizedTest
+ @MethodSource("dataTypeProvider")
+ public void testApplyPredicate(Tuple3 tuple3) {
+ PredicateBuilder builder =
+ new PredicateBuilder(
+ new RowType(
+ Collections.singletonList(
+ new DataField(0, "fieldName", tuple3.dataType))));
+ test(
+ builder.isNull(0),
+ new ParquetFilters.IsNull("fieldName", tuple3.dataType),
+ tuple3.canPushDown);
+ test(
+ builder.isNotNull(0),
+ new ParquetFilters.Not(new ParquetFilters.IsNull("fieldName", tuple3.dataType)),
+ tuple3.canPushDown);
+ test(
+ builder.equal(0, tuple3.value),
+ new ParquetFilters.Equals("fieldName", tuple3.dataType, tuple3.value),
+ tuple3.canPushDown);
+
+ test(
+ builder.notEqual(0, tuple3.value),
+ new ParquetFilters.Not(
+ new ParquetFilters.Equals("fieldName", tuple3.dataType, tuple3.value)),
+ tuple3.canPushDown);
+ test(
+ builder.lessThan(0, tuple3.value),
+ new ParquetFilters.LessThan("fieldName", tuple3.dataType, tuple3.value),
+ tuple3.canPushDown);
+ test(
+ builder.lessOrEqual(0, tuple3.value),
+ new ParquetFilters.LessThanEquals("fieldName", tuple3.dataType, tuple3.value),
+ tuple3.canPushDown);
+ test(
+ builder.greaterThan(0, tuple3.value),
+ new ParquetFilters.Not(
+ new ParquetFilters.LessThanEquals(
+ "fieldName", tuple3.dataType, tuple3.value)),
+ tuple3.canPushDown);
+ test(
+ builder.greaterOrEqual(0, tuple3.value),
+ new ParquetFilters.Not(
+ new ParquetFilters.LessThan("fieldName", tuple3.dataType, tuple3.value)),
+ tuple3.canPushDown);
+ }
+
+ static Stream<Tuple3> dataTypeProvider() {
+ return Stream.of(
+ Tuple3.of(new RowType(Lists.newArrayList()), null, false),
+ Tuple3.of(new MultisetType(new TimeType()), null, false),
+ Tuple3.of(new ArrayType(new TimeType()), null, false),
+ Tuple3.of(new MapType(new BooleanType(), new BooleanType()), null, false),
+ Tuple3.of(new BinaryType(), Binary.fromString("a"), true),
+ Tuple3.of(new VarBinaryType(), Binary.fromString("b"), true),
+ Tuple3.of(new CharType(), Binary.fromString("c"), true),
+ Tuple3.of(new VarCharType(), Binary.fromString("paimon"), true),
+ Tuple3.of(new TimeType(), LocalTime.now(), true),
+ Tuple3.of(new DateType(), LocalDate.now(), true),
+ Tuple3.of(new TimestampType(), LocalDateTime.now(), true),
Review Comment:
I don't think so, you can take a look to `ParquetRowDataWriter.timestampToInt96`, that is not Binary order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org