You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ndimiduk <gi...@git.apache.org> on 2015/12/08 19:23:39 UTC
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
GitHub user ndimiduk opened a pull request:
https://github.com/apache/flink/pull/1442
[FLINK-3147] HadoopOutputFormatBase should expose mutexes for subclasses
Simple patch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ndimiduk/flink 3147-hadoopoutputformatbase-mutexes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1442
----
commit 94701d18ba6e47c033765ff8b0e444ce42a776d5
Author: Nick Dimiduk <nd...@apache.org>
Date: 2015-12-08T18:20:58Z
[FLINK-3147] HadoopOutputFormatBase should expose mutexes for subclasses
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164883472
I will cherry-pick the commit over to the 0.10 branch. Thanks @ndimiduk!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-162991974
Thanks for the patch!
Can you apply the same changes to `org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormatBase`, the base class for `mapred` API OutputFormats?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by ndimiduk <gi...@git.apache.org>.
Github user ndimiduk commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-162987985
I pushed an updated change to the same branch, not sure why the PR didn't pick it up. https://github.com/ndimiduk/flink/commit/333aa03fe7f509fd2dff6f56476d7ba4b3da6289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by ndimiduk <gi...@git.apache.org>.
Github user ndimiduk commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164882643
Should I post a second PR for merging to 0.10-SNAPSHOT, or will you handle cherry-pick to active release branches? Thanks a lot @fhueske !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164828376
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-163074809
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164880422
Thanks for the PR! I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by ndimiduk <gi...@git.apache.org>.
Github user ndimiduk commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-163010606
Sure thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3147] HadoopOutputFormatBase should exp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---