You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2019/03/06 12:43:40 UTC
[GitHub] [griffin] aborgatin commented on a change in pull request #484:
GRIFFIN-232 - add support pluggable predicates
aborgatin commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#discussion_r262923746
##########
File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java
##########
@@ -185,17 +185,13 @@ private void setPredicates(String json) throws IOException {
if (StringUtils.isEmpty(json)) {
return;
}
- List<Map<String, Object>> maps = toEntity(json,
- new TypeReference<List<Map>>() {
+ List<SegmentPredicate> predicates = toEntity(json,
Review comment:
Yes, this code is covered in tests. I add yet another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services