[jira] [Commented] (HBASE-11406) ExportSnapshot#run better catch Throwable for ExportSnapshot#runCopyJob

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063025#comment-14063025 ] 

Hadoop QA commented on HBASE-11406:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12652172/hbase11406-master.patch
  against trunk revision .
  ATTACHMENT ID: 12652172

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10079//console

This message is automatically generated.

> ExportSnapshot#run better catch Throwable for ExportSnapshot#runCopyJob
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11406
>                 URL: https://issues.apache.org/jira/browse/HBASE-11406
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Qiang Tian
>            Assignee: Qiang Tian
>            Priority: Trivial
>         Attachments: hbase11406-master.patch
>
>
> ExportSnapshot#run better catch Throwable for ExportSnapshot#runCopyJob since runCopyJob involves hadoop and mapreduce. other errors could be thrown, catching them like below at first place is helpful for error handling and problem identification.
> 14/06/24 18:39:30 ERROR snapshot.ExportSnapshot: Snapshot export failed
> java.lang.NoSuchMethodError: org/apache/hadoop/mapred/JobTracker.getAddress(Lorg/apache/hadoop/conf/Configuration;)Ljava/net/InetSocketAddress;
>         at org.apache.hadoop.mapred.JobTrackerClientProtocolProvider.create(JobTrackerClientProtocolProvider.java:44)
>         at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
>         at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:82)
>         at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:75)
>         at org.apache.hadoop.hbase.mapreduce.JobUtil.getStagingDir(JobUtil.java:54)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.getInputFolderPath(ExportSnapshot.java:541)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.runCopyJob(ExportSnapshot.java:609)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.run(ExportSnapshot.java:776)
>         at org.apache.hadoop.hbase.backup.BackupCopier.copy(BackupCopier.java:248)
>         at org.apache.hadoop.hbase.backup.BackupHandler.snapshotCopy(BackupHandler.java:559)
>         at org.apache.hadoop.hbase.backup.BackupHandler.call(BackupHandler.java:141)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:314)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:897)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:919)
>         at java.lang.Thread.run(Thread.java:738)



--
This message was sent by Atlassian JIRA
(v6.2#6252)