You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/29 02:36:29 UTC

[kudu-CR] [tools] update on 'kudu table create' command

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18796


Change subject: [tools] update on 'kudu table create' command
......................................................................

[tools] update on 'kudu table create' command

This patch updates the code related to the kudu CLI command
'table create':
  * added 'owner' field to CreateTablePB/JSON
  * added 'comment' field to CreateTablePB/JSON
  * updated corresponding comments in the tool.proto file
  * fixed the example of the JSON object for CreateTablePB
  * made the example of JSON object for CreateTablePB redable
  * re-ordered string constants in tool_action_table.cc
  * other minor updates

Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_table.cc
2 files changed, 98 insertions(+), 49 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18796/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
Gerrit-Change-Number: 18796
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tools] update on 'kudu table create' command

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18796 )

Change subject: [tools] update on 'kudu table create' command
......................................................................

[tools] update on 'kudu table create' command

This patch updates the code related to the kudu CLI command
'table create':
  * added 'owner' field to CreateTablePB/JSON
  * added 'comment' field to CreateTablePB/JSON
  * updated corresponding comments in the tool.proto file
  * fixed the example of the JSON object for CreateTablePB
  * made the example of JSON object for CreateTablePB redable
  * re-ordered string constants in tool_action_table.cc
  * other minor updates

Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
Reviewed-on: http://gerrit.cloudera.org:8080/18796
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_table.cc
2 files changed, 98 insertions(+), 49 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Abhishek Chennaka: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
Gerrit-Change-Number: 18796
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tools] update on 'kudu table create' command

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18796 )

Change subject: [tools] update on 'kudu table create' command
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
Gerrit-Change-Number: 18796
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 18:50:31 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] update on 'kudu table create' command

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18796 )

Change subject: [tools] update on 'kudu table create' command
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2855ee07e0dae4df669e6dd1d5ad4281d3b906b
Gerrit-Change-Number: 18796
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 16:52:49 +0000
Gerrit-HasComments: No