You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Weijie Guo (Jira)" <ji...@apache.org> on 2024/04/08 02:14:00 UTC
[jira] [Comment Edited] (FLINK-35009) Change on getTransitivePredecessors breaks connectors
[ https://issues.apache.org/jira/browse/FLINK-35009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834751#comment-17834751 ]
Weijie Guo edited comment on FLINK-35009 at 4/8/24 2:13 AM:
------------------------------------------------------------
This change can be done in a compatible way. But one could argue that {{Transformation}} is not actually a public API(marked as {{@Internal}} indeed). The connector depend on it somehow shouldn't be guaranteed.
BTW: The {{MockTransformation}} in kafka-connector seems unused and can be removed safely.
was (Author: weijie guo):
This change can be done in a compatible way. But one could argue that {{Transformation}} is not actually a public API(marked as {{@Internal}} indeed). The connector's depend on it somehow shouldn't be guaranteed.
BTW: The {{MockTransformation}} in kafka-connector seems unused and can be removed safely.
> Change on getTransitivePredecessors breaks connectors
> -----------------------------------------------------
>
> Key: FLINK-35009
> URL: https://issues.apache.org/jira/browse/FLINK-35009
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Connectors / Kafka
> Affects Versions: 1.18.2, 1.20.0, 1.19.1
> Reporter: Martijn Visser
> Priority: Blocker
>
> {code:java}
> Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project flink-connector-kafka: Compilation failure: Compilation failure:
> Error: /home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java:[214,24] org.apache.flink.streaming.connectors.kafka.testutils.DataGenerators.InfiniteStringsGenerator.MockTransformation is not abstract and does not override abstract method getTransitivePredecessorsInternal() in org.apache.flink.api.dag.Transformation
> Error: /home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java:[220,44] getTransitivePredecessors() in org.apache.flink.streaming.connectors.kafka.testutils.DataGenerators.InfiniteStringsGenerator.MockTransformation cannot override getTransitivePredecessors() in org.apache.flink.api.dag.Transformation
> Error: overridden method is final
> {code}
> Example: https://github.com/apache/flink-connector-kafka/actions/runs/8494349338/job/23269406762#step:15:167
--
This message was sent by Atlassian Jira
(v8.20.10#820010)