[GitHub] [netbeans] JaroslavTulach commented on pull request #2643: Display Java + Truffle guest frames correctly.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2643:
URL: https://github.com/apache/netbeans/pull/2643#issuecomment-756546389


   > I've removed the old unused sdk and truffle-api JARs.
   
   +1
   
   > But I've retained truffle-sl, it's needed by tests.
   
   +1
   
   > We should probably create a lib with truffle-sl, like `ide/libs.trufflesl` right? It might be handy for tests elsewhere.
   
   I am not sure there is a general need for `truffle-sl`. There is `graal-js` available as a library and very likely it is better to test against JavaScript rather than SL in majority of cases. I no longer remember why we selected `truffle-sl` rather than JavaScript, but that is OK, `truffle-sl` can stay "hidden" as a test library in this module. 
   
   > For tests of this I'll need 20.3 truffle API and SL. I can add tests as soon as we upgrade the Truffle version.
   
   Upgrading to 20.3 is desirable. Let's aim to have it for NetBeans 12.3.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists