You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/23 17:27:11 UTC
[GitHub] [cloudstack] pavanaravapalli opened a new pull request #3985: NPE
fix for System VM's start Command
pavanaravapalli opened a new pull request #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985
## Description
<!--- Describe your changes in detail -->
System VM's are failed to deploy on VM ware setup, due to NPE.
Solution : Added Null check for the same and took care of respective code flow changes.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Yet to test and update.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request
#3985: NPE fix for System VM's start Command
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#discussion_r396740464
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2286,7 +2286,7 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
- if (!bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
+ if (StringUtils.isNotBlank(bootMode) && !bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
Review comment:
@pavanaravapalli bootMode compared with boot type. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani removed a comment on issue #3985: NPE fix
for System VM's start Command
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603041341
Tested on VMware, Systemvms are coming up normally. LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request
#3985: NPE fix for System VM's start Command
Posted by GitBox <gi...@apache.org>.
pavanaravapalli commented on a change in pull request #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#discussion_r396899019
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2286,7 +2286,7 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
- if (!bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
+ if (StringUtils.isNotBlank(bootMode) && !bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
Review comment:
@sureshanaparti
here the purpose is to have bootMode initialise with default value and utilise it with uefi enabled vmprofile or normal vmprofile validation. however the constant which is used leads to confusion so i have made changes and fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request
#3985: NPE fix for System VM's start Command
Posted by GitBox <gi...@apache.org>.
pavanaravapalli commented on a change in pull request #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#discussion_r396899019
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2286,7 +2286,7 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
- if (!bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
+ if (StringUtils.isNotBlank(bootMode) && !bootMode.equalsIgnoreCase(ApiConstants.BootType.BIOS.toString())) {
Review comment:
@sureshanaparti
here the purpose is to have bootMode initialise with default value and utilise it with uefi enabled vmprofile or normal vmprofile. however the constant which is used confusing so i have done changes and fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603426378
<b>Trillian test result (tid-1292)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27373 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1292-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 0.31 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603152610
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603033464
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603465062
<b>Trillian test result (tid-1293)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1293-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 0.51 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603152342
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603449272
<b>Trillian test result (tid-1291)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3985-t1291-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 0.34 | test_kubernetes_supported_versions.py
test_01_scale_vm | `Failure` | 17.67 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani edited a comment on issue #3985: NPE fix
for System VM's start Command
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603041341
Tested on VMware, Systemvms are coming up normally. LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on issue #3985: NPE fix for
System VM's start Command
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #3985: NPE fix for System VM's start Command
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-603041341
Tested on VMware, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services