[GitHub] [maven-resolver] michael-o commented on a change in pull request #148: [MRESOLVER-237] Make all checksum mismatches handled same

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #148:
URL: https://github.com/apache/maven-resolver/pull/148#discussion_r795601130



##########
File path: maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java
##########
@@ -223,6 +224,16 @@ else if ( checksumPolicy.onChecksumMatch( factory.getName(), ChecksumKind.REMOTE
         return false;
     }
 
+    private static ChecksumFailureException createChecksumFailureException( ChecksumKind kind,
+                                                                            String expected,
+                                                                            String actual )
+    {
+        return new ChecksumFailureException(
+            "'" + expected + "' (" + kind.name() + ")",
+            "'" + actual + "' (actual)"
+        );

Review comment:
       Not a huge fan becaue it changes those checksums, cannot be reused. I would expect a new ctor overload to pass the kind.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org