You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "JiaLiangC (via GitHub)" <gi...@apache.org> on 2023/10/11 01:57:52 UTC
[PR] AMBARI-26008: Add openEuler operating system support [ambari]
JiaLiangC opened a new pull request, #3757:
URL: https://github.com/apache/ambari/pull/3757
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
Posted by "brahmareddybattula (via GitHub)" <gi...@apache.org>.
brahmareddybattula commented on PR #3757:
URL: https://github.com/apache/ambari/pull/3757#issuecomment-1937459601
@JiaLiangC thanks for reporting and working on this. Looks there are conflicts with PR. Can you please rebase the PR.?
Dn't we need to merge py3 PR's first.? and CI is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
Posted by "wenwj0 (via GitHub)" <gi...@apache.org>.
wenwj0 commented on PR #3757:
URL: https://github.com/apache/ambari/pull/3757#issuecomment-1962918716
> @MacChen01 @brahmareddybattula
>
> This PR is somewhat disruptive as it changes a lot of content. Essentially, the limitation of Ambari's support for multiple operating systems is just to ensure the use of the correct package management tool during installation. Therefore, after upgrading to Python 3, supporting different operating systems becomes easy. It only requires modifying the OS check logic to categorize operating systems based on the package manager. For instance, operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', thus uniformly using YUM as the package manager. On the other hand, those using APT would be classified as 'ubuntu'. Our production environment has already adopted this new approach, making support for new operating systems extremely convenient, requiring changes to just one file, oscheck.py. Adding support for new operating systems in the future will become very easy. Therefore, I am still considering whether to close this PR and discuss on the mailing list whether we
need to change so much code to add a new operating system or if there is a simpler way to extend support for other operating systems.
>
> As shown in the following image: support for many operating systems has been added by merely changing this code. 
+1 for this idea.
Many operating systems now use YUM as the package manager. If these OS can be grouped into one category, it will be much simpler to add similar operating systems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
Posted by "timyuer (via GitHub)" <gi...@apache.org>.
timyuer commented on PR #3757:
URL: https://github.com/apache/ambari/pull/3757#issuecomment-1958986006
> @MacChen01 @brahmareddybattula
>
> This PR is somewhat disruptive as it changes a lot of content. Essentially, the limitation of Ambari's support for multiple operating systems is just to ensure the use of the correct package management tool during installation. Therefore, after upgrading to Python 3, supporting different operating systems becomes easy. It only requires modifying the OS check logic to categorize operating systems based on the package manager. For instance, operating systems like Red Hat 7, 8, 9, and openEuler would return 'redhat', thus uniformly using YUM as the package manager. On the other hand, those using APT would be classified as 'ubuntu'. Our production environment has already adopted this new approach, making support for new operating systems extremely convenient, requiring changes to just one file, oscheck.py. Adding support for new operating systems in the future will become very easy. Therefore, I am still considering whether to close this PR and discuss on the mailing list whether we
need to change so much code to add a new operating system or if there is a simpler way to extend support for other operating systems.
>
> As shown in the following image: support for many operating systems has been added by merely changing this code. 
@JiaLiangC
This is a good idea, but this approach is not very standardized. Do you think we may need to consider restructuring the structure of ambari? Welcome to open the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
Posted by "wenwj0 (via GitHub)" <gi...@apache.org>.
wenwj0 commented on PR #3757:
URL: https://github.com/apache/ambari/pull/3757#issuecomment-1936972907
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] AMBARI-26008: Add openEuler operating system support [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC closed pull request #3757: AMBARI-26008: Add openEuler operating system support
URL: https://github.com/apache/ambari/pull/3757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org