[GitHub] [spark] MaxGekk commented on a change in pull request #30529: [SPARK-33588][SQL] Respect the `spark.sql.caseSensitive` config while resolving partition spec in v1 `SHOW TABLE EXTENDED`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #30529:
URL: https://github.com/apache/spark/pull/30529#discussion_r532263402



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala
##########
@@ -84,6 +85,30 @@ trait ShowTablesSuiteBase extends command.ShowTablesSuiteBase {
       result.foreach { case Row(_, _, _, info: String) => assert(info.nonEmpty) }
     }
   }
+
+  test("case sensitivity of partition spec") {
+    withNamespace(s"$catalog.ns") {
+      sql(s"CREATE NAMESPACE $catalog.ns")
+      val t = s"$catalog.ns.part_table"
+      withTable(t) {
+        sql(s"""
+          |CREATE TABLE $t (price int, qty int, year int, month int)
+          |$defaultUsing
+          |partitioned by (year, month)""".stripMargin)

Review comment:
       I am working on V2 SHOW TABLE EXTENDED: https://issues.apache.org/jira/browse/SPARK-33393 at the moment. When I will be moving the test to the common test suite to run it for both V1 and V2, I will address your comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org