[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection methods on JobConf

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271458#comment-13271458 ] 

Hadoop QA commented on MAPREDUCE-2338:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526158/MR2338.3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.mapred.lib.TestKeyFieldBasedComparator

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2372//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2372//console

This message is automatically generated.
                
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
>                 Key: MAPREDUCE-2338
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: James Warren
>              Labels: newbie
>         Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira