You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/07/24 20:41:23 UTC

[commons-pool] branch master updated: Checkstyle.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/master by this push:
     new 581eb6d  Checkstyle.
581eb6d is described below

commit 581eb6d07ddc2bfc3bdd3fc0bad4064b10414469
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jul 24 16:41:11 2019 -0400

    Checkstyle.
---
 .../java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java | 4 ++--
 src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java     | 3 +++
 src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java     | 7 ++++---
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
index 562e1ac..6910c37 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
@@ -520,8 +520,8 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T>
 
     /**
      * Whether there is at least one thread waiting on this deque, add an pool object.
-     * @param key
-     * @param idleObjects
+     * @param key pool key.
+     * @param idleObjects list of idle pool objects.
      */
     private void whenWaitersAddObject(final K key, final LinkedBlockingDeque<PooledObject<T>> idleObjects) {
         if (idleObjects.hasTakeWaiters()) {
diff --git a/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java b/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
index a40cad6..835742c 100644
--- a/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
+++ b/src/main/java/org/apache/commons/pool2/impl/NoOpCallStack.java
@@ -31,6 +31,9 @@ public class NoOpCallStack implements CallStack {
      */
     public static final CallStack INSTANCE = new NoOpCallStack();
 
+    /**
+     * Constructs the singleton instance.
+     */
     private NoOpCallStack() {
     }
 
diff --git a/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java b/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
index f3a84bf..94ae100 100644
--- a/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
+++ b/src/main/java/org/apache/commons/pool2/impl/PoolImplUtils.java
@@ -108,11 +108,12 @@ class PoolImplUtils {
     /**
      * Gets the matching parameterized type or null.
      * @param type
-     *            The interface that defines a generic type
+     *            The interface that defines a generic type.
      * @param clazz
-     *            The class that implements the interface with a concrete type
+     *            The class that implements the interface with a concrete type.
      * @param <T>
-     *            The interface type
+     *            The interface type.
+     * @return the matching parameterized type or null.
      */
     private static <T> ParameterizedType getParameterizedType(final Class<T> type, final Class<? extends T> clazz) {
         for (final Type iface : clazz.getGenericInterfaces()) {